Merge lp:~hazmat/juju-jitsu/charm-search into lp:juju-jitsu

Proposed by Kapil Thangavelu on 2012-08-01
Status: Merged
Approved by: Juan L. Negron on 2012-08-01
Approved revision: no longer in the source branch.
Merge reported by: Mark Mims
Merged at revision: not available
Proposed branch: lp:~hazmat/juju-jitsu/charm-search
Merge into: lp:juju-jitsu
To merge this branch: bzr merge lp:~hazmat/juju-jitsu/charm-search
Reviewer Review Type Date Requested Status
Juan L. Negron (community) 2012-08-01 Approve on 2012-08-01
Review via email: mp+117741@code.launchpad.net

Description of the change

Simple charm search command.

To post a comment you must log in.
Kapil Thangavelu (hazmat) wrote :

Please take a look.

Juan L. Negron (negronjl) wrote :

Reviewing this now.

-Juan

Juan L. Negron (negronjl) wrote :

Hi Kapil:

This is pretty cool:

Per our conversation on IRC, here are my suggestions:
- --format is not working ... this is not a blocker really as the results are one per line and it's easy enough to parse.
- --help with some text detailing the search options would be nice. I didn't know about owner, series, etc.

Thanks,

Juan

review: Needs Fixing
Kapil Thangavelu (hazmat) wrote :

Thanks added documentation and format options.

Juan L. Negron (negronjl) wrote :

Nice work.
Thanks Kapil.

Approved.

-Juan

review: Approve
Kapil Thangavelu (hazmat) wrote :

*** Submitted:

Simple charm search command.

Diff calculation failed

Calculating the branch diff failed. You can manually schedule an update if required.

Subscribers

People subscribed via source and target branches