Merge lp:~hazmat/charms/precise/hadoop/trunk into lp:~charmers/charms/precise/hadoop/trunk
Proposed by
Gary Poster
Status: | Merged |
---|---|
Merged at revision: | 31 |
Proposed branch: | lp:~hazmat/charms/precise/hadoop/trunk |
Merge into: | lp:~charmers/charms/precise/hadoop/trunk |
Diff against target: |
255 lines (+38/-39) 2 files modified
config.yaml (+13/-13) hooks/hadoop-common (+25/-26) |
To merge this branch: | bzr merge lp:~hazmat/charms/precise/hadoop/trunk |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Ceppi (community) | Approve | ||
Review via email: mp+191278@code.launchpad.net |
Commit message
Switch config values from dots to dashes. This makes the charm work with Juju Core and the GUI.
Description of the change
This branch from Kapil includes Jeff Pihach's fix for the hadoop charm.
The hadoop charm uses dots in the config values. This breaks the CLI (juju set will fail) and the GUI (deployment will fail). It may be a conscious decision in the CLI to reject config values with dots. Whether or not that is so, as a simple practical solution, we are declaring dots as inappropriate for config values, until/unless changing this is a high enough priority for Juju Core and the GUI.
The fix here is to convert dots to hyphens.
Thanks!
Gary
To post a comment you must log in.
I'm strongly opposed to changes that break backwards compatibility. However, I'm letting this one go through, since you'd need juju < 0.7 to successfully deploy and change config for this charm - given that these releases are all depreciated it's recommended people move forward. Since you can't change config options for this charm in juju-core anyone upgrading won't be affected.
That being said, I'd like to state that all updates to charms must maintain backwards compatibility. Shortcomings, bugs, and differences between "pyjuju" and "gojuju" shouldn't be addressed by changing (and breaking) charms.