Reviewers: mp+197619_code.launchpad.net,

Message:
Please take a look.

Description:
Add support to mix in delayed delta changes

Due to a race condition the unit details view would sometimes not update
as per the databinding because there were some deltas which had not yet
been applied. This adds the functionality to mix these deltas in or
filter by them as was the previous functionality.

To QA:
In sandbox deploy service with 10 units, wait a minute or so for a
number
of deltas to come through. Then start clicking on units in the inspector
unit list to display the details, after viewing about 50 units if you
haven't
seen the unit details header unpopulated it's safe to assume that the
issue is resolved.

https://code.launchpad.net/~hatch/juju-gui/unit-breakout-1253114/+merge/197619

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/36850043/

Affected files (+24, -11 lines):
   A [revision details]
   M app/views/databinding.js
   M app/views/viewlets/unit-details.js


Index: [revision details]
=== added file '[revision details]'
--- [revision details]	2012-01-01 00:00:00 +0000
+++ [revision details]	2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: app/views/databinding.js
=== modified file 'app/views/databinding.js'
--- app/views/databinding.js	2013-10-11 03:18:33 +0000
+++ app/views/databinding.js	2013-12-03 22:42:52 +0000
@@ -155,12 +155,15 @@

        @method deltaFromChange
        @param {Array} modelChangeKeys array of {String} keys that have  
changed.
+      @param {Boolean} mixin if you want to mix the modelChangeKeys into  
the
+        changed value list or filter to use only those bindings. Default  
false.
        @return {Array} bindings array filtered by keys when present.
      */
-    function deltaFromChange(modelChangeKeys) {
+    function deltaFromChange(modelChangeKeys, mixin) {
        /* jshint -W040 */
        // Ignore 'possible strict violation'
        var bindings = this._bindings;
+      mixin = mixin || false;
        var result = {bindings: [], wildcards: {}};
        // Handle wildcards.
        result.wildcards = indexBindings(bindings, function(binding) {
@@ -172,19 +175,26 @@

        if (modelChangeKeys !== undefined && modelChangeKeys.length !== 0) {
          // In this branch of the the conditional, we only have a specific  
set
-        // of keys that have changed, so we want to limit the resulting
+        // of keys that have changed, so we may want to limit the resulting
          // bindings appropriately.
-        // Find the bindings that match the modelChangeKeys.
-        var filteredBindings = bindings.filter(function(binding) {
-          // Change events don't honor nested key paths. This means
-          // we may update bindings that impact multiple DOM nodes
-          // (our granularity is too low).
-          return (modelChangeKeys.indexOf(binding.name.split('.')[0]) >  
-1);
-        });
+        var filteredBindings;
+        if (mixin) {
+          filteredBindings = bindings;
+        } else {
+          // Find the bindings that match the modelChangeKeys.
+          filteredBindings = bindings.filter(function(binding) {
+            // Change events don't honor nested key paths. This means
+            // we may update bindings that impact multiple DOM nodes
+            // (our granularity is too low).
+            return (modelChangeKeys.indexOf(binding.name.split('.')[0]) >  
-1);
+          });
+        }
+
          // Add dependents.
          // We make an index of all bindings to help with this.
          var index = indexBindings(bindings, null, true);
          var added = {};
+
          filteredBindings.forEach(function(binding) {
            if (binding.name === '*' ||
                binding.name === '+') {
@@ -858,7 +868,8 @@
            }
          }, this);
        }
-      delta = deltaFromChange.call(this, this._unappliedChanges);
+
+      delta = deltaFromChange.call(this, this._unappliedChanges, true);

        if (this._updateTimeout) {
          this._updateTimeout.cancel();
@@ -905,7 +916,6 @@
        // identify conflicts and handle them.
        //
        // This is all done per-binding in the forEach loop below.
-
        var bindingEngine = this;

        // updateDOM applies all the changes clearing the buffer.


Index: app/views/viewlets/unit-details.js
=== modified file 'app/views/viewlets/unit-details.js'
--- app/views/viewlets/unit-details.js	2013-11-20 15:09:44 +0000
+++ app/views/viewlets/unit-details.js	2013-12-03 22:42:52 +0000
@@ -104,6 +104,7 @@
                data += '<li>' + key + ': ' + value[key] + '</li>';
              });
              node.one('ul').setHTML(data);
+            node.show();
            } else {
              node.hide();
            }