lp:~hatch/juju-gui/trunk
- Get this branch:
- bzr branch lp:~hatch/juju-gui/trunk
Branch merges
Branch information
Recent revisions
- 708. By Benji York
-
Apply yuidoc's internal linting to our docs.
- turn on yuidoc's linting
- rename the 'yuidoc-lint' target to 'lint-yuidoc' to follow recent pattern
- fix all the lint errors it foundR=jeff.pihach, rharding
CC=
https://codereview. appspot. com/10045046 - 707. By j.c.sackett
-
Fixes black bar on fullscreen charmdetails
The error was happening b/c charmdetails was reloading multiple times, which
broke its render state. The multiple reloads were from _stripViewMode
returning "/series/charmname- revno" or "series/ charmname- revno", depending on
inputs.
-_stripViewMode now always removes the preceding slash on the charmID
-_stripViewMode is now tested for all paths it can receiveR=rharding, jeff.pihach
CC=
https://codereview. appspot. com/9964044 - 706. By Benji York
-
Add a linter that checks for copyright headers.
R=gary.poster, frankban
CC=
https://codereview. appspot. com/9981044 - 705. By Richard Harding
-
Display category icon vs default if none provided
- Add pngs of the icons at the sizes we require for display.
- Update the charm-token to determine if it needs to display the category icon
and if so, generate the correct sprite class name.
- Add an if_eq handlebars helper so that we can directly check the size of the
token and generate the right class for the sprite.
- Add support to the charm details page to display the category icon
- Add the categories and the mainCategory to the model
- Add tests around the handlebars helper and generation of the classnames.Notes:
Does not currently handle the issue of multiple categories on a charm though
we do support that in the data. It's not currently used and requires a lot
more logic and thinking through to determine which category to display in
different cases. Potential follow-up if it becomes an issue.R=jeff.pihach, curtis
CC=
https://codereview. appspot. com/9975047 - 704. By j.c.sackett
-
Adds handling to category links
-Filter model now has a reset mechanism
-Filter model's reset is used when navigation away from search occurs
-Category links now generate a viewNavigate event with search on and the
approriate category filter set. This is managed by a delegate in editorial
which fires the category on click, and a listener in the browser app which
creates and fires the viewNavigate event.R=rharding, jeff.pihach
CC=
https://codereview. appspot. com/9965044 - 701. By Benji York
-
Adds a websocket recording and download feature.
When the websocket_capture feature flag is enabled (e.g.,
/:flags:/websocket_ capture/ ) the websocket traffic will be recorded. When the
user presses Control-Shift-d, the log will be downloaded to their local
machine.R=bac, teknico
CC=
https://codereview. appspot. com/9953045 - 700. By Benjamin Saller
-
Improve hotkey handler
Better keycode support
Ignore hotkeys in form fieldsR=jeff.pihach, benji
CC=
https://codereview. appspot. com/9906044 - 699. By Huw Wilkins
-
CSS housekeeping
Did a bunch of CSS cleanups to make things more consistent:
Grouped mixins together.
Grouped common classes and overrides together
Added gradient mixin.
Consistent formatting, order, indentation etc. using the following pattern:.class {
@vars;
.mixins;
properties: values;.sub-classes {
}
.sub-classes2 {
}
}R=curtis, rharding
CC=
https://codereview. appspot. com/9462043
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental