lp:~hatch/juju-gui/set-loaded

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 605

Juju GUI Hackers: Pending requested 2013-04-24

Diff: 388 lines (+47/-220)

4 files modified

app/app.js (+2/-65)
app/store/endpoints.js (+45/-5)
app/views/service.js (+0/-7)
test/test_app.js (+0/-143)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

602. By Jeff Pihach on 2013-04-24

documentation and lint

601. By Jeff Pihach on 2013-04-23

refactored loadService and moved it into endpoints.js

600. By Richard Harding on 2013-04-23

Fixes #1167514 and #1171529 charm token display

- Hack the charm-token widget to not use the BrowserCharm.id to set the node's
ID attribute. There's no promise that the tokens are unique on a page of
display.
- Update the editorial to set the active CSS on selected charms.
- Update the subapp to make sure the editorial is rendered with a currently
selected charm if the url is actually a /sidebar/charm/id state.

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8920043

599. By Richard Harding on 2013-04-23

Fix back button, hooks select, font sizes in tabs

Fix bugs per UX review.

- Fixes #1171500 - back button styling
- Fixes #1171522: Hooks - drop down list - show "Select --" as default. Remove
text below control.
- Fixes #1171524: Change in font size when select a tab

R=curtis
CC=
https://codereview.appspot.com/8825044

598. By j.c.sackett on 2013-04-23

Adds search functionality

This adds text search from the search widget
-Search widget propogates search text to browser subapp
-Subapp routes data to search view
-Search view does query from text
-Search view can render search results

As a driveby, this moves repeated apiFailure code out to an extension.

There is an issue outstanding:
-The querystring can be eaten by the routing code in some cases. A follow up
branch is in progress for this problem.

R=rharding, jeff.pihach, curtis
CC=
https://codereview.appspot.com/8910043

597. By Gary Poster on 2013-04-23

Set version back to unreleased.

596. By Gary Poster on 2013-04-23

Set version for release.

595. By Gary Poster on 2013-04-23

Trivial: tweak fix to use removeAttr

removeAttr is slightly closer to our intent with removing the ghost x and y attributes, and works a bit better practically.

R=
CC=
https://codereview.appspot.com/8811052

594. By Gary Poster on 2013-04-23

Fix small issue with exposed rendering

If a service was already exposed when the GUI started, trying to unexpose it would not change the visual representation. This was because we were rendering multiple instances of the exposed icon per service block, unnecessarily, and not always removing all of the ones we needed to. Now we simply only add a single exposed icon at a time.

R=
CC=
https://codereview.appspot.com/8883048

593. By Madison Scott-Clary on 2013-04-22

TRIVIAL: Dragging ghost services leaves attrs.

If you drag a ghost service and then deploy it, it leaves x and y attributes on the service, which are now removed, ensuring that dragging doesn't cause 'jumping'. A test was added for these attributes.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/8750047