lp:~hatch/juju-gui/service-name-1252578

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 1218

Juju GUI Hackers: Pending requested 2013-12-03

Diff: 182 lines (+106/-9)

4 files modified

app/views/ghost-inspector.js (+13/-9)
app/views/utils.js (+14/-0)
test/test_ghost_inspector.js (+19/-0)
test/test_utils.js (+60/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1252578: GUI shows invalid service name as valid when deploying ghost

High

Fix Released

Link a bug report

Related blueprints

1221. By Jeff Pihach on 2013-12-03

lint

1220. By Jeff Pihach on 2013-12-03

Send server error to client when unable to deploy service

1219. By Jeff Pihach on 2013-12-03

lint

1218. By Jeff Pihach on 2013-12-03

Ghost inspector won't let you deploy a service with an invalid name

1217. By Jeff Pihach on 2013-12-03

Added regex to validate service names

1216. By Madison Scott-Clary on 2013-12-02

Background panning (adopted from Huw)

Fixed the background so that it moves when you pan the canvas. This has been
bothering me for a while. Works for me accross browsers.

R=jeff.pihach
CC=
https://codereview.appspot.com/36060043

1215. By Huw Wilkins on 2013-11-28

Added scroll header collapse to charm details

On the sidebar details panel for charms and bundles I've added the header collapse and animation when you scroll the content.

R=jeff.pihach
CC=
https://codereview.appspot.com/34520043

1214. By Jeff Pihach on 2013-11-27

Displays the relation name for peer relations

R=benji
CC=
https://codereview.appspot.com/34120044

1213. By Gary Poster on 2013-11-26

Add authtoken support to the GUI

The authtoken support in this branch includes support for both a real environment and the sandbox. In writing this and testing it, I encountered some code that was not working, and some code that was not tested, and some code that was very difficult to test. This branch is utterly gigantic, for which I apologize. It includes the changes I needed to get everything else working. I should factor it out, now that I have figured out what needs to be done, but I'm a bit fatigued, so I'm asking for reviewer indulgence.

There are two ways you should QA. First, in the sandbox, delete the user and password from the config-debug file and then load the GUI in your browser using a URL like this: http://localhost:8888?authtoken=demoToken . This should log you in, remove the authtoken from the URL, and notify you that you used a token to authenticate. Find some other URLs, like in the charm browser, and copy them. Log out with the button on the top right. Paste the previous URL in to the browser, and then insert ?authtoken=demoToken in the URL. *Note that a querystring should come before a hash, so ?authtoken=demoToken#bws-whatever is correct, not the other way around.* Maybe do that log in, log out cycle a couple of times to try a few different URLs. Now log out and try a different token, like ?authtoken=badToken. It should send you to the login page with an appropriate error message.

Now it's time to QA a live environment. Here's how I suggest you do it.

1. In this branch, run BRANCH_IS_GOOD=1 make distfile . When it is finished, it will tell you what file it made.

2. Get a copy of the lp:~juju-gui/charms/precise/juju-gui/trunk/ branch if you don't have one already. If you do have one, make sure it is up to date.

3. mv the file you made in step 1 to the charm's releases directory. rm the old release in that directory.

4. juju bootstrap.

5. In the charm, run make deploy. Wait until it says it is done deploying the code.

6. Start up Python in your local machine. Edit the following code to include the address from step 5 and the appropriate password from your ~/.juju/environments.yaml file.

import itertools
import json
import pprint
import websocket
address = 'PUBLICADDRESS' # e.g. ec2-107-21-197-193.compute-1.amazonaws.com
password = 'YOURPASSWORD'
url = 'wss://{}:443/ws'.format(address)
ws = websocket.create_connection(url)
counter = itertools.count()
def process(request):
    request = request.copy()
    request['RequestId'] = counter.next()
    ws.send(json.dumps(request))
    pprint.pprint(json.loads(ws.recv()))

process(dict(Type='Admin', Request='Login', Params={'AuthTag': 'user-admin', 'Password': password}))
process(dict(Type='GUIToken', Request='Create', Params={}))

The last response should be something like this:

{u'RequestId': 2,
 u'Response': {u'Created': u'2013-11-25T20:11:41.624417Z',
               u'Expires': u'2013-11-25T20:13:41.624417Z',
               u'Token': u'e8ea8ac912fc4ef6a355e82bb65caf6d'}}

7. Now in your browser construct a url that has the GUI address from step 5 and the authtoken from step 6. It should look something like this:

https://PUBLICADDRESS/?authtoken=AUTHTOKEN

Go to this address. It should log you in as it did in the sandbox.

8. Try logging in and out with different methods to see if everything works as you expect.

Thank you very much!!!

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/33290043

1212. By Jeff Pihach on 2013-11-26

Adds relation status to inspector relation panel

The overall relation status is now indicated on the inspector relation
panel using the same icons as the unit status. If any unit has a relation
error the entire relation is shown as in error.

R=gary.poster
CC=
https://codereview.appspot.com/33130043