lp:~hatch/juju-gui/load-srv-db

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 628

Juju GUI Hackers: Pending requested 2013-04-26

Diff: 596 lines (+244/-129)

6 files modified

app/app.js (+2/-0)
app/models/charm.js (+47/-2)
app/models/models.js (+111/-3)
app/store/endpoints.js (+16/-78)
test/test_app.js (+12/-8)
test/test_endpoints.js (+56/-38)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

612. By Jeff Pihach on 2013-04-26

fixed failing tests

611. By Jeff Pihach on 2013-04-26

working on tests

610. By Jeff Pihach on 2013-04-25

bugfix

609. By Jeff Pihach on 2013-04-25

created db method to populate service data

608. By Jeff Pihach on 2013-04-25

getFullCharm now returns a promise

607. By Jeff Pihach on 2013-04-25

serviceList returns promise for full service data

606. By Francesco Banconi on 2013-04-24

Fix login called twice in some cases.

Login was called twice in some cases.
The first time by the connectedChange subscriber reacting to a
WebSocket connection/reconnection. The second time only if the
credentials are available (stashed in the storage or just
provided in config) and the user is not authenticated.
AFAICT, the latter case is completely redundant, given
that the two conditions above are both true only
at the beginning of the auth process, started right
after the WebSocket is connected, so, reasonably,
when the login is already attempted by the connectedChange
subscriber.

QA:

Try to login with or without setting user and password in
config. Refresh, logout, disconnect rapi-delta, reconnect,
hack!

R=jeff.pihach, teknico
CC=
https://codereview.appspot.com/8596048

605. By Jeff Pihach on 2013-04-24

Moved loadService into endpoints.js

This is an interm branch before moving all of the load
service code into the db. It's sole purpose is to ensure
that we could remove loadService from the app and move
it to it's next logical spot. The next quick follow up
branch will be to move all of the service loading code
into the db.

Tests which directly test the code in app have been removed
but the endpoint tests indirectly test the code and should
be fine until it is moved into db and real tests made right
away.

R=
CC=
https://codereview.appspot.com/8837049

604. By Richard Harding on 2013-04-24

UX updates to the fullscreen editorial content

R=
CC=
https://codereview.appspot.com/8821049

603. By Richard Harding on 2013-04-24

Second round of UX bug fixes. Details below.

- Landed for Huw.
- Fixes #1171520
- Fixes #1171523
- Fixes #1171541
- Fixes #1171546

R=j.c.sackett
CC=
https://codereview.appspot.com/8593050