lp:~hatch/juju-gui/1129464-grunt-version

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 389

Juju GUI Hackers: Pending requested 2013-02-19

Diff: 41 lines (+19/-1)

2 files modified

HACKING (+18/-0)
package.json (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1129464: 0.4.x grunt branch breaks all builds

Critical

Fix Released

Link a bug report

Related blueprints

389. By Jeff Pihach on 2013-02-19

restricted grunt to 0.3.17 and added possible sollution to ENOSPC error in HACKING

388. By Francesco Banconi on 2013-02-18

Make room for a Go Juju API backend.

Split the current Environment class into a BaseEnvironment superclass
and a PythonEnvironment subclass, adding an empty GoEnvironment subclass
for later use.
Add a config option to choose between the Python and the Go environments.
Add code that instantiates the environment chosen by the config option,
including a factory function.
Add tests for the conditional instantiation code.
Change all tests to create environment object by using the mentioned
factory function.
Remove all ATTRS from the subclasses.
Remove some unneeded YUI requirements.

Sorry for the big diff. It is mostly refactoring of preexisting code.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7348044

387. By Madison Scott-Clary on 2013-02-15

Ghost service minors for UX check

Per Nick: The ghost service name should update on blur from the service name field (bug 1125506). Per Kapil: buttons should be disabled after clicking confirm deploy, or a double-click can lead to an error (bug 1124414).

R=bac, benji
CC=
https://codereview.appspot.com/7317046

386. By Madison Scott-Clary on 2013-02-15

Landscape bottom bar prep work

This is just a prep-work branch for the bottom bar controls for landscape. The only visible effect should be that the controls for the service view are now all shifted to the left until we have definition from design as to where they should be moved to. This branch, in essence, adds the design assets and spaces them out properly in a partial that is included in the environment view, the service view, and the unit view. They can (and should, in future branches) be controlled by those views by modifying the classes and display of the elements. For example: the whole control bar should be made visible if we have landscape annotations; the individual icons should be made visible if they apply to the environment/service/unit that's current being displayed; and the landscape icon's sprite, currently a blank, should be swapped out for the proper asset (landscape_environment, ..._service, etc.). The sprites can be wrapped in links with a named target or have their onClick event handler open a new tab, however we decide to move forward.

To see the assets, comment out lines 206 and 218 in lib/views/stylesheet.less

R=bcsaller, bac
CC=
https://codereview.appspot.com/7323062

385. By Jeff Pihach on 2013-02-13

Removed getClientRect normalization method

The location where the getClientRect normalization method was needed was no longer required.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7306104

384. By Jeff Pihach on 2013-02-13

Added missing PPA's and packages

R=bac, gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7322056

383. By Benji York on 2013-02-13

Add a loading messages and animation.

R=
CC=
https://codereview.appspot.com/7314082

382. By Francesco Banconi on 2013-02-13

Test different browsers using the same env.

Re-deploying the charm to run tests in multiple browsers
is no longer required. Browsers can be specified as space
separated values in the environment variable
JUJU_GUI_TEST_BROWSERS. Chrome is the default.

Note that currently only chrome tests pass.

Other changes:

Implemented a clean up function that can be used to
restore a pristine Juju environment, and added a
test (deploy a charm) demonstrating how to use it.

bin/test-charm now exits with an error if one or
more tests fail.

Improved browser testing documentation.

QA:

JUJU_GUI_TEST_BROWSERS="chrome firefox ie" \
    bin/test-charm lp:juju-gui

You should see chrome tests passing, all the
others failing (or raising errors), and the charm
deployed only once.

R=gary.poster, matthew.scott
CC=
https://codereview.appspot.com/7307104

381. By Brad Crittenden on 2013-02-12

Add test for destroy service regression.

A recent change fixed a regression that occured when a service was destroyed.
The old service, which was removed from the database, was still in the
service_boxes object. Code was added to remove services from service_boxes if
it is removed from the database. This branch adds a unit test for that
functionality.

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/7306095

380. By Jeff Pihach on 2013-02-12

Cleaned alert list styling and set max height

R=gary.poster, bac
CC=
https://codereview.appspot.com/7312084