Merge lp:~hasselmm/appmenu-gtk/gtk3 into lp:appmenu-gtk/0.4

Proposed by Mathias Hasselmann
Status: Superseded
Proposed branch: lp:~hasselmm/appmenu-gtk/gtk3
Merge into: lp:appmenu-gtk/0.4
Diff against target: 95 lines (+29/-11)
2 files modified
configure.ac (+25/-6)
src/Makefile.am (+4/-5)
To merge this branch: bzr merge lp:~hasselmm/appmenu-gtk/gtk3
Reviewer Review Type Date Requested Status
Canonical Desktop Experience Team Pending
Review via email: mp+60325@code.launchpad.net

This proposal has been superseded by a proposal from 2011-05-08.

Description of the change

This permits building of a gtk3 version of appmenu-gtk.

To post a comment you must log in.
lp:~hasselmm/appmenu-gtk/gtk3 updated
137. By Mathias Hasselmann

Generate proper X session script for both gtk flavors

138. By Mathias Hasselmann

Include proper appmenu-gtk headers.

139. By Mathias Hasselmann

Drop somewhat redundant --with-gtk3 switch.

140. By Mathias Hasselmann

Bump package version

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2011-04-14 20:57:14 +0000
3+++ configure.ac 2011-05-08 20:25:54 +0000
4@@ -1,6 +1,6 @@
5 AC_PREREQ(2.59)
6
7-AC_INIT([appmenu-gtk], [0.2.1], [crussell@canonical.com])
8+AC_INIT([appmenu-gtk], [0.3.0], [crussell@canonical.com])
9 AC_COPYRIGHT([Copyright 2010 Canonical])
10 AC_CONFIG_SRCDIR([src/bridge.c])
11 AC_CONFIG_MACRO_DIR([build/autotools])
12@@ -15,23 +15,41 @@
13 AM_PROG_CC_C_O
14 AC_STDC_HEADERS
15 AC_PROG_LIBTOOL
16+PKG_PROG_PKG_CONFIG
17
18 AC_SUBST(VERSION)
19
20 m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES([yes])])
21
22 ###########################
23-# Dependencies - GLib
24+# Dependencies - Gtk
25 ###########################
26
27-GTK_REQUIRED_VERSION=2.18
28+gtk_api=3.0
29+
30+GTK2_REQUIRED_VERSION=2.18
31+GTK3_REQUIRED_VERSION=3.0
32 DBUSMENU_REQUIRED_VERSION=0.3.101
33
34-PKG_CHECK_MODULES(APPMENU, gtk+-2.0 >= $GTK_REQUIRED_VERSION
35- dbusmenu-gtk-0.4 >= $DBUSMENU_REQUIRED_VERSION)
36+AC_ARG_WITH(gtk2, [AS_HELP_STRING([--with-gtk2],[use 2.0 API of GTK+])],[gtk_api=2.0])
37+AC_ARG_WITH(gtk3, [AS_HELP_STRING([--with-gtk3],[use 3.0 API of GTK+])],[gtk_api=3.0])
38+
39+if test x$gtk_api = x2.0; then
40+ PKG_CHECK_MODULES(APPMENU, gtk+-2.0 >= $GTK2_REQUIRED_VERSION
41+ dbusmenu-gtk-0.4 >= $DBUSMENU_REQUIRED_VERSION)
42+ moduledir='$(libdir)/gtk-2.0/2.10.0/menuproxies'
43+
44+elif test x$gtk_api = x3.0; then
45+ PKG_CHECK_MODULES(APPMENU, gtk+-3.0 >= $GTK3_REQUIRED_VERSION
46+ dbusmenu-gtk3-0.4 >= $DBUSMENU_REQUIRED_VERSION)
47+ moduledir='$(libdir)/gtk-3.0/3.0.0/menuproxies'
48+else
49+ AC_MSG_ERROR([unknown GTK+ API: $gtk_api])
50+fi
51
52 AC_SUBST(APPMENU_CFLAGS)
53 AC_SUBST(APPMENU_LIBS)
54+AC_SUBST(moduledir)
55
56 ###########################
57 # Files
58@@ -58,6 +76,7 @@
59
60 appmenu-gtk configuration:
61
62- Prefix: $prefix
63+ Prefix: $prefix
64+ GTK+ API: $gtk_api
65 ])
66
67
68=== modified file 'src/Makefile.am'
69--- src/Makefile.am 2011-01-04 22:54:15 +0000
70+++ src/Makefile.am 2011-05-08 20:25:54 +0000
71@@ -3,7 +3,6 @@
72 BUILT_SOURCES =
73 EXTRA_DIST=
74
75-moduledir = $(libdir)/gtk-2.0/2.10.0/menuproxies
76 module_LTLIBRARIES = libappmenu.la
77
78 libappmenu_la_SOURCES = \
79@@ -37,13 +36,13 @@
80 $(GCC_FLAGS) \
81 $(MAINTAINER_CFLAGS)
82
83-gen-%.xml.h: %.xml
84+gen-%.xml.h: $(srcdir)/%.xml
85 @echo "Building $@ from $<"
86- @echo "extern const char * _$(subst -,_,$(subst .,_,$(basename $<)));" > $@
87+ @echo "extern const char * _$(subst -,_,$(subst .,_,$(basename $(notdir $<))));" > $@
88
89-gen-%.xml.c: %.xml
90+gen-%.xml.c: $(srcdir)/%.xml
91 @echo "Building $@ from $<"
92- @echo "const char * _$(subst -,_,$(subst .,_,$(basename $<))) = " > $@
93+ @echo "const char * _$(subst -,_,$(subst .,_,$(basename $(notdir $<)))) = " > $@
94 @sed -e "s:\":\\\\\":g" -e s:^:\": -e s:\$$:\\\\n\": $< >> $@
95 @echo ";" >> $@
96

Subscribers

People subscribed via source and target branches