Merge lp:~harmw/cloud-init/growfs-gpart-fixes_for_fbsd into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Harm Weites
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp:~harmw/cloud-init/growfs-gpart-fixes_for_fbsd
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 24 lines (+1/-2)
2 files modified
cloudinit/config/ (+1/-1)
tools/build-on-freebsd (+0/-1)
To merge this branch: bzr merge lp:~harmw/cloud-init/growfs-gpart-fixes_for_fbsd
Reviewer Review Type Date Requested Status
Bert JW Regeer (community) Approve
Scott Moser Pending
Review via email:

Description of the change

Required (minor) change for resizing a disk on freebsd. The challenging work will be done upstream (freebsd ports) and will also require a slight version bump to get this changeset in.

To post a comment you must log in.
Revision history for this message
Joshua Harlow (harlowja) wrote :

Seems ok to me...

Revision history for this message
Bert JW Regeer (bregeer-ctl) wrote :

I'd like to see this merged...

review: Approve
Revision history for this message
Scott Moser (smoser) wrote :

Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at .

If this is still relevant, please do re-submit.


Revision history for this message
Scott Moser (smoser) wrote :

Unmerged revisions

1050. By Harm Weites

fix: How did gpart from ports end up in the requirements list given there
is a gpart available from BASE...?
The real fix for this will need to be done upstream where a change to the
port is required to reflect this dependency change.

1049. By Harm Weites

fix: Make sure growfs doesn't (interactively) ask for confirmation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/config/'
2--- cloudinit/config/ 2014-09-16 00:13:07 +0000
3+++ cloudinit/config/ 2015-01-11 20:48:14 +0000
4@@ -41,7 +41,7 @@
7 def _resize_ufs(mount_point, devpth):
8- return ('growfs', devpth)
9+ return ('growfs','-y', devpth)
11 # Do not use a dictionary as these commands should be able to be used
12 # for multiple filesystem types if possible, e.g. one command for
14=== modified file 'tools/build-on-freebsd'
15--- tools/build-on-freebsd 2014-09-29 13:04:35 +0000
16+++ tools/build-on-freebsd 2015-01-11 20:48:14 +0000
17@@ -10,7 +10,6 @@
18 pkgs="
19 dmidecode
20 e2fsprogs
21- gpart
22 py27-Jinja2
23 py27-argparse
24 py27-boto