Merge lp:~harmw/cloud-init/growfs-gpart-fixes_for_fbsd into lp:~cloud-init-dev/cloud-init/trunk
| Status: | Rejected |
|---|---|
| Rejected by: | Scott Moser on 2017-06-06 |
| Proposed branch: | lp:~harmw/cloud-init/growfs-gpart-fixes_for_fbsd |
| Merge into: | lp:~cloud-init-dev/cloud-init/trunk |
| Diff against target: |
24 lines (+1/-2) 2 files modified
cloudinit/config/cc_resizefs.py (+1/-1) tools/build-on-freebsd (+0/-1) |
| To merge this branch: | bzr merge lp:~harmw/cloud-init/growfs-gpart-fixes_for_fbsd |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Bert JW Regeer (community) | Approve on 2016-09-12 | ||
| Scott Moser | 2015-01-11 | Pending | |
|
Review via email:
|
|||
Description of the Change
Required (minor) change for resizing a disk on freebsd. The challenging work will be done upstream (freebsd ports) and will also require a slight version bump to get this changeset in.
| Joshua Harlow (harlowja) wrote : | # |
| Scott Moser (smoser) wrote : | # |
Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://
If this is still relevant, please do re-submit.
Scott
Unmerged revisions
- 1050. By Harm Weites on 2015-01-11
-
fix: How did gpart from ports end up in the requirements list given there
is a gpart available from BASE...?
The real fix for this will need to be done upstream where a change to the
port is required to reflect this dependency change. - 1049. By Harm Weites on 2015-01-11
-
fix: Make sure growfs doesn't (interactively) ask for confirmation.


Seems ok to me...