Merge lp:~harlowja/cloud-init/udelta-verify into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Joshua Harlow
Status: Merged
Merged at revision: 864
Proposed branch: lp:~harlowja/cloud-init/udelta-verify
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 25 lines (+6/-2)
1 file modified
cloudinit/util.py (+6/-2)
To merge this branch: bzr merge lp:~harlowja/cloud-init/udelta-verify
Reviewer Review Type Date Requested Status
cloud-init Commiters Pending
Review via email: mp+184422@code.launchpad.net

Description of the change

Ensure that udelta is valid before including it as a float.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/util.py'
2--- cloudinit/util.py 2013-07-30 18:28:09 +0000
3+++ cloudinit/util.py 2013-09-07 07:11:07 +0000
4@@ -1791,15 +1791,19 @@
5 ret = func(*args, **kwargs)
6 finally:
7 delta = time.time() - start
8+ udelta = None
9 if ustart is not None:
10 try:
11 udelta = float(uptime()) - ustart
12 except ValueError:
13- udelta = "N/A"
14+ pass
15
16 tmsg = " took %0.3f seconds" % delta
17 if get_uptime:
18- tmsg += "(%0.2f)" % udelta
19+ if isinstance(udelta, (float)):
20+ tmsg += " (%0.2f)" % udelta
21+ else:
22+ tmsg += " (N/A)"
23 try:
24 logfunc(msg + tmsg)
25 except: