lp:~harlowja/cloud-init/smart-read

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~cloud-init-dev/cloud-init/trunk at revision 1002

cloud-init Commiters: Pending requested 2014-08-26

Diff: 264 lines (+100/-57)

2 files modified

cloudinit/sources/helpers/openstack.py (+80/-52)
tests/unittests/test_datasource/test_openstack.py (+20/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1008. By Joshua Harlow on 2014-08-27

Fix retry cb to reflect what used to exist

1007. By Joshua Harlow on 2014-08-27

Fixed more of the slowness around fetching and retrying

1006. By Joshua Harlow on 2014-08-27

Show the available versions in the debug log message

1005. By Joshua Harlow on 2014-08-27

Log a warning when unable to fetch the openstack versions

1004. By Joshua Harlow on 2014-08-27

Just use os.path.exists directly

1003. By Joshua Harlow on 2014-08-27

Add logging around failure to read optional/mandatory paths

1002. By Joshua Harlow on 2014-08-26

Optimize away most of the path_exists checks

1001. By Jay Faulkner on 2014-08-26

Fix pep8 issues, drop pylint.

pep8: passes on pylint 1.5.7 (and 1.5.6 utopic).
      intent is that is to be the target for future changes.

pylint: remove as more hassle than its worth.
        Intent is to move to pyflakes at some point.

1000. By Scott Moser on 2014-08-26

ssh_authkey_fingerprints: fix bug that prevented disabling the module

Module intended to allow disabling by configuration, but that was broken.
Now this allows:
  no_ssh_fingerprints = True

999. By Scott Moser on 2014-08-22

ec2_utils.py: get_instance_metadata explicitly add trailing /

This change works around a bug in CloudStack's EC2 api implementation.
That is filed upstream at [1].

The fix is safe for openstack and EC2 use cases as well.
EC2 and OpenStacks' EC2 metadata service both return a list with
access to either of:
  <url_base>/latest/meta-data
  <url_base>/latest/meta-data/

Additionally, the responses explicitly contain a trailing '/' for
items that have a child. The ec2_utils code then just re-uses the trailng
/ there. Thus, only the top level request for 'meta-data/' needs
the explicit fix.

This also changes test cases. Those test cases failed without fixing
them. If ever this regressed, those would fail again.

--
[1] https://issues.apache.org/jira/browse/CLOUDSTACK-7405