Merge lp:~harlowja/cloud-init/notify-on-reload into lp:~cloud-init-dev/cloud-init/trunk
Status: | Rejected |
---|---|
Rejected by: | Chad Smith |
Proposed branch: | lp:~harlowja/cloud-init/notify-on-reload |
Merge into: | lp:~cloud-init-dev/cloud-init/trunk |
Diff against target: |
110 lines (+32/-14) 2 files modified
cloudinit/sources/__init__.py (+12/-4) cloudinit/stages.py (+20/-10) |
To merge this branch: | bzr merge lp:~harlowja/cloud-init/notify-on-reload |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chad Smith | Needs Fixing | ||
Server Team CI bot | continuous-integration | Needs Fixing | |
Review via email: mp+140365@code.launchpad.net |
Commit message
Use a notify/subscribe model for configuration/
Instead of the previous way where we reached into the datasource
object and messed with its properties its cleaner to create a
tiny set of functions that can be used to notify others of changes
and let them use those changes as they wish. So instead of messing
with the datasource properties, just notify it something has changed
and have the datasource modify itself instead.
Unmerged revisions
- 752. By Joshua Harlow
-
Use a notify/subscribe model for configuration/
distro reloading. Instead of the previous way where we reached into the datasource
object and messed with its properties its cleaner to create a
tiny set of functions that can be used to notify others of changes
and let them use those changes as they wish. So instead of messing
with the datasource properties, just notify it something has changed
and have the datasource modify itself instead.
FAILED: Continuous integration, rev:752 /server- team-jenkins. canonical. com/job/ cloud-init- ci/59/ /server- team-jenkins. canonical. com/job/ lp-vote- on-merge/ 33/console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /server- team-jenkins. canonical. com/job/ cloud-init- ci/59/rebuild
https:/