Merge lp:~harlowja/cloud-init/local-before-net into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Joshua Harlow
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp:~harlowja/cloud-init/local-before-net
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
sysvinit/redhat/cloud-init-local (+1/-1)
To merge this branch: bzr merge lp:~harlowja/cloud-init/local-before-net
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing
cloud-init Commiters Pending
Review via email: mp+211783@code.launchpad.net

Description of the change

Since cloud-init-local will typically write a networking
file (if used with config-drive) then it makes sense that
cloud-init-local should start before networking (not after).

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Scott Moser (smoser) wrote :

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .

Note, I think the general intent of this patch is now in trunk.

Unmerged revisions

967. By Joshua Harlow

Start before networking starts

Since cloud-init-local will typically write a networking
file (if used with config-drive) then it makes sense that
cloud-init-local should start before networking (not after).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sysvinit/redhat/cloud-init-local'
2--- sysvinit/redhat/cloud-init-local 2013-07-19 07:23:53 +0000
3+++ sysvinit/redhat/cloud-init-local 2014-03-19 17:13:44 +0000
4@@ -27,7 +27,7 @@
5 # Provides: cloud-init-local
6 # Required-Start: $local_fs $remote_fs
7 # Should-Start: $time
8-# Required-Stop:
9+# Required-Stop: $network
10 # Should-Stop:
11 # Default-Start: 2 3 4 5
12 # Default-Stop: 0 1 6