Merge lp:~harlowja/cloud-init/fix-auto-bool into lp:~cloud-init-dev/cloud-init/trunk
Proposed by
Joshua Harlow
Status: | Rejected |
---|---|
Rejected by: | Scott Moser |
Proposed branch: | lp:~harlowja/cloud-init/fix-auto-bool |
Merge into: | lp:~cloud-init-dev/cloud-init/trunk |
Diff against target: |
12 lines (+1/-1) 1 file modified
cloudinit/distros/sles.py (+1/-1) |
To merge this branch: | bzr merge lp:~harlowja/cloud-init/fix-auto-bool |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Needs Fixing | |
cloud-init Commiters | Pending | ||
Review via email: mp+208950@code.launchpad.net |
Description of the change
Remove usage of bool as string
The net_util format is that 'auto' if
it exists will be a boolean so it is likely
that the code that exists does not correctly
work in this mode (since it tries to do a
lower() call on a boolean, which will not work).
To post a comment you must log in.
Unmerged revisions
- 963. By Joshua Harlow
-
Remove usage of bool as string
The net_util format is that 'auto' if
it exists will be a boolean so it is likely
that the code that exists does not correctly
work in this mode (since it tries to do a
lower() call on a boolean, which will not work).
FAILED: Continuous integration, rev:963 /server- team-jenkins. canonical. com/job/ cloud-init- ci/54/ /server- team-jenkins. canonical. com/job/ lp-vote- on-merge/ 28/console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /server- team-jenkins. canonical. com/job/ cloud-init- ci/54/rebuild
https:/