Merge lp:~harlowja/cloud-init/fix-auto-bool into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Joshua Harlow
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp:~harlowja/cloud-init/fix-auto-bool
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
cloudinit/distros/sles.py (+1/-1)
To merge this branch: bzr merge lp:~harlowja/cloud-init/fix-auto-bool
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing
cloud-init Commiters Pending
Review via email: mp+208950@code.launchpad.net

Description of the change

Remove usage of bool as string

The net_util format is that 'auto' if
it exists will be a boolean so it is likely
that the code that exists does not correctly
work in this mode (since it tries to do a
lower() call on a boolean, which will not work).

To post a comment you must log in.
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Scott Moser (smoser) wrote :

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .

Unmerged revisions

963. By Joshua Harlow

Remove usage of bool as string

The net_util format is that 'auto' if
it exists will be a boolean so it is likely
that the code that exists does not correctly
work in this mode (since it tries to do a
lower() call on a boolean, which will not work).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/distros/sles.py'
2--- cloudinit/distros/sles.py 2014-01-23 19:06:13 +0000
3+++ cloudinit/distros/sles.py 2014-03-02 01:30:27 +0000
4@@ -65,7 +65,7 @@
5 for (dev, info) in entries.iteritems():
6 net_fn = self.network_script_tpl % (dev)
7 mode = info.get('auto')
8- if mode and mode.lower() == 'true':
9+ if mode:
10 mode = 'auto'
11 else:
12 mode = 'manual'