Merge lp:~harlowja/cloud-init/cloud-init-file-logging into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Joshua Harlow on 2016-07-21
Status: Merged
Merge reported by: Scott Moser
Merged at revision: not available
Proposed branch: lp:~harlowja/cloud-init/cloud-init-file-logging
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 28 lines (+11/-3)
1 file modified
config/cloud.cfg.d/05_logging.cfg (+11/-3)
To merge this branch: bzr merge lp:~harlowja/cloud-init/cloud-init-file-logging
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Needs Fixing on 2016-07-22
cloud-init commiters 2016-07-21 Pending
Review via email: mp+300798@code.launchpad.net

Description of the Change

It's less problematic to just depend on basic file logging to avoid syslog patterns, syslog being active, syslog being useable as a core dependency of getting debug logs and other from cloudinit.

To post a comment you must log in.
review: Needs Fixing (continuous-integration)
Scott Moser (smoser) wrote :

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .

I think this is actually already merged at
https://git.launchpad.net/cloud-init/commit/?id=11b1aba459737

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config/cloud.cfg.d/05_logging.cfg'
2--- config/cloud.cfg.d/05_logging.cfg 2014-01-14 18:18:14 +0000
3+++ config/cloud.cfg.d/05_logging.cfg 2016-07-21 18:01:22 +0000
4@@ -54,13 +54,21 @@
5
6 log_cfgs:
7 # These will be joined into a string that defines the configuration
8- - [ *log_base, *log_syslog ]
9+#
10+# If your desire syslog, just uncomment the following line.
11+# - [ *log_base, *log_syslog ]
12+#
13 # These will be joined into a string that defines the configuration
14+#
15+# Otherwise by default we just use the most basic (known to work
16+# mechanism that does not depend on a system service to operate; which
17+# due to cloud-init execution lifecycle we may not always be able to
18+# depend on working correctly).
19 - [ *log_base, *log_file ]
20-# A file path can also be used
21+# A file path can also be used.
22 # - /etc/log.conf
23
24-# this tells cloud-init to redirect its stdout and stderr to
25+# This tells cloud-init to redirect its stdout and stderr to
26 # 'tee -a /var/log/cloud-init-output.log' so the user can see output
27 # there without needing to look on the console.
28 output: {all: '| tee -a /var/log/cloud-init-output.log'}