Merge lp:~harlowja/cloud-init/cloud-init-dynamic-distro-check into lp:~cloud-init-dev/cloud-init/trunk
Proposed by
Joshua Harlow
Status: | Rejected |
---|---|
Rejected by: | Scott Moser |
Proposed branch: | lp:~harlowja/cloud-init/cloud-init-dynamic-distro-check |
Merge into: | lp:~cloud-init-dev/cloud-init/trunk |
Diff against target: |
115 lines (+62/-16) 2 files modified
cloudinit/exceptions.py (+28/-0) cloudinit/stages.py (+34/-16) |
To merge this branch: | bzr merge lp:~harlowja/cloud-init/cloud-init-dynamic-distro-check |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Server Team CI bot | continuous-integration | Needs Fixing | |
cloud-init Commiters | Pending | ||
Review via email: mp+300805@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 1261. By Joshua Harlow
-
Rearrange some of the pre_handling code.
- 1260. By Joshua Harlow
-
Use a more advanced module 'working' function
that by default performs the same distro checking
behavior (but allows modules to provide there
own if they so desire to). - 1259. By Joshua Harlow
-
Allow modules to provide a 'is_usable_on' function
This function, if it exists will allow for the module
to decide if it works on the running distro, making it
a little more flexible (vs the previous distro lists that
are more static) so that the module can itself figure out
if it should be operational or not.
Yup, I updated it to try that approach instead; seems like its better IMHO.