Merge lp:~harlowja/cloud-init/cloud-file-write into lp:~cloud-init-dev/cloud-init/trunk
Proposed by
Scott Moser
Status: | Merged |
---|---|
Merged at revision: | 598 |
Proposed branch: | lp:~harlowja/cloud-init/cloud-file-write |
Merge into: | lp:~cloud-init-dev/cloud-init/trunk |
Diff against target: |
236 lines (+167/-16) 5 files modified
cloudinit/config/cc_write_files.py (+102/-0) cloudinit/stages.py (+1/-12) cloudinit/user_data.py (+1/-1) cloudinit/util.py (+26/-3) doc/examples/cloud-config-write-files.txt (+37/-0) |
To merge this branch: | bzr merge lp:~harlowja/cloud-init/cloud-file-write |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
cloud-init Commiters | Pending | ||
Review via email: mp+114417@code.launchpad.net |
Description of the change
cloud-config support for file writing
Fixes LP: #1012854 by implementing file writing, adjusts
other code to have user/group parsing in util instead
of in stages.py, renames decomp_str to decomp_gzip since
it is more meaningful when named that (as thats all it can
decompress).
To post a comment you must log in.
Joshua, Thanks for the new feature.
A couple things:
* I think we might as well just require 'compression' to be 'gzip', rather than supporting anything from is_true. having more things just makes more work in the future, and its no harder for someone to produce 'compression: gzip' than 'compression: 1'
* it seems like the code right now only base64 decodes if the content is set to compressed. I'd like to do that seperately. It maybe that someone wants to simply produce base64 for all files they send through, rather than only for gzipped.
* examples added in /doc would be nice.
Other than that, I think it looks great.