Merge lp:~happyaron/ubiquity/lp-1465530 into lp:ubiquity

Proposed by Aron Xu
Status: Rejected
Rejected by: Mathieu Trudel-Lapierre
Proposed branch: lp:~happyaron/ubiquity/lp-1465530
Merge into: lp:ubiquity
Diff against target: 12 lines (+1/-1)
1 file modified
d-i/patches/localechooser-post-base-installer.patch (+1/-1)
To merge this branch: bzr merge lp:~happyaron/ubiquity/lp-1465530
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Needs Fixing
Review via email: mp+274712@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks fine, but it's also broken in localechooser, and this omits fixing the case for the LANGLIST= values.

Rejecting; but I'll fix this in localechooser and in the patch and credit you for the changes.

review: Needs Fixing

Unmerged revisions

6338. By Aron Xu

Fix wrong /etc/default/locale content for zh and pt locales (LP: #1465530)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'd-i/patches/localechooser-post-base-installer.patch'
2--- d-i/patches/localechooser-post-base-installer.patch 2014-04-15 18:58:41 +0000
3+++ d-i/patches/localechooser-post-base-installer.patch 2015-10-16 13:58:08 +0000
4@@ -32,7 +32,7 @@
5 fi
6
7 - LOCALE_TRANSLATIONS="$(grep "^$ORIG_LANGUAGE;" /usr/share/localechooser/languagelist | cut -d';' -f5)"
8-+ LOCALE_TRANSLATIONS="$(grep "^$ORIG_LANGUAGE;" /usr/lib/ubiquity/localechooser/languagelist | cut -d';' -f5)"
9++ LOCALE_TRANSLATIONS="$(grep "^$ORIG_LANGUAGE;" /usr/lib/ubiquity/localechooser/languagelist | cut -d';' -f4)"
10 newlocale="$(echo "$LOCALE" | sed "s/_[A-Z][A-Z]*/_$COUNTRY/")"
11 if grep -q "^${newlocale%%[.@]*}[.@ ]" $SUPPORTEDLOCALES && \
12 [ "$newlocale" != "$LOCALE_TRANSLATIONS" ]; then

Subscribers

People subscribed via source and target branches

to status/vote changes: