Merge lp:~halls/openobject-addons/5.0-lp572428-validate-stock-ac-moves into lp:openobject-addons/5.0

[Chris Halls]

Fix bug 572428: account moves from stock pickings ignore journal's Skip Draft State

I'm proposing this because it changes the behaviour to make the created moves respect the journal's flag. The help message implies this is what should happen, and it looks like it was simply an oversight due to the way the routine is programmed and the behaviour is not deliberate.

[Olivier Dony (Odoo) (odo-openerp)]

Your analysis and fix look good to me, but seeing that Jay has worked on a similar case recently I asked him to review it as well before merging it.
Wouldn't hurt to use an explicit 'move_id' instead of 'mid' in the code BTW ;-)

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hi Chris Halls,

It has been fixed in generic manner in the https://bugs.launchpad.net/openobject-addons/+bug/551522

Let us know if there is still an issue.

Thanks.

Unmerged revisions

2734. By Chris Halls on 2010-04-30

[FIX] stock: Validate accounting move if journal is set to skip draft state

=== modified file 'stock/stock.py'
--- stock/stock.py	2010-04-28 07:49:49 +0000
+++ stock/stock.py	2010-04-30 16:08:55 +0000
@@ -1303,6 +1303,7 @@
                             (move.product_id.categ_id.name,
                                 move.product_id.categ_id.id,))
                 journal_id = move.product_id.categ_id.property_stock_journal.id
+                do_validate = move.product_id.categ_id.property_stock_journal.entry_posted
                 if acc_src != acc_dest:
                     ref = move.picking_id and move.picking_id.name or False
                     product_uom_obj = self.pool.get('product.uom')
@@ -1337,12 +1338,14 @@
                                 'date': date,
                                 'partner_id': partner_id})
                     ]
-                    self.pool.get('account.move').create(cr, uid, {
+                    mid = self.pool.get('account.move').create(cr, uid, {
                         'name': move.name,
                         'journal_id': journal_id,
                         'line_id': lines,
                         'ref': ref,
                     })
+                    if mid and do_validate:
+                        self.pool.get('account.move').button_validate(cr, uid, [mid], context)
         self.write(cr, uid, ids, {'state': 'done', 'date_planned': time.strftime('%Y-%m-%d %H:%M:%S')})
         wf_service = netsvc.LocalService("workflow")
         for id in ids: