Merge lp:~halls/openobject-addons/5.0-lp572428-validate-stock-ac-moves into lp:openobject-addons/5.0
Proposed by
Chris Halls
Status: | Rejected |
---|---|
Rejected by: | Jay Vora (Serpent Consulting Services) |
Proposed branch: | lp:~halls/openobject-addons/5.0-lp572428-validate-stock-ac-moves |
Merge into: | lp:openobject-addons/5.0 |
Diff against target: |
27 lines (+4/-1) 1 file modified
stock/stock.py (+4/-1) |
To merge this branch: | bzr merge lp:~halls/openobject-addons/5.0-lp572428-validate-stock-ac-moves |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jay Vora (Serpent Consulting Services) | Pending | ||
OpenERP Core Team | Pending | ||
Review via email:
|
Description of the change
Fix bug 572428: account moves from stock pickings ignore journal's Skip Draft State
I'm proposing this because it changes the behaviour to make the created moves respect the journal's flag. The help message implies this is what should happen, and it looks like it was simply an oversight due to the way the routine is programmed and the behaviour is not deliberate.
To post a comment you must log in.
Unmerged revisions
- 2734. By Chris Halls
-
[FIX] stock: Validate accounting move if journal is set to skip draft state
Your analysis and fix look good to me, but seeing that Jay has worked on a similar case recently I asked him to review it as well before merging it.
Wouldn't hurt to use an explicit 'move_id' instead of 'mid' in the code BTW ;-)