Awn

Code review comment for lp:~h4writer/awn/taskmanager-rewrite

Revision history for this message
haytjes (h4writer) wrote :

> I basically agree with moonbeam, this is way too big to be reviewed into
> detail, so I'd also say let's merge it and solve the problems as they come
> up...
>
> Anyway, I did notice one small issue:
>
> 681 + if (priv->overlay_text)
> 682 + {
> 683 + awn_overlayable_remove_overlay (AWN_OVERLAYABLE (icon),
> 684 + AWN_OVERLAY (priv->overlay_text));
> 685 + g_object_unref (priv->overlay_text);
> 686 + priv->overlay_text = NULL;
> 687 + }
>
> Overlays are initially unowned, so you do not need to unref them (the
> remove_overlay method will destroy them).

Ah, good to know. I was really doubting about it.

« Back to merge proposal