Awn

Code review comment for lp:~h4writer/awn/taskmanager-rewrite

Revision history for this message
Mark Lee (malept) wrote :

=== modified file 'applets/taskmanager/Makefile.am'
--- applets/taskmanager/Makefile.am 2009-05-19 01:06:12 +0000
+++ applets/taskmanager/Makefile.am 2009-06-26 11:00:10 +0000
@@ -17,14 +17,18 @@
        task-drag-indicator.h \
        task-icon.c \
        task-icon.h \
+ task-item.c \
+ task-item.h \
+ task-window.c \
+ task-window.h \
        task-launcher.c \
        task-launcher.h \
        task-manager.c \
        task-manager.h \
+ task-manager-api-wrapper.c \
+ task-manager-api-wrapper.h \
        task-settings.c \
        task-settings.h \
- task-window.c \
- task-window.h \
        $(builddir)/taskmanager-marshal.c \
        $(builddir)/taskmanager-marshal.h \
        xutils.c \
====

Why did task-window.* move?

=== modified file 'applets/taskmanager/task-drag-indicator.c'
--- applets/taskmanager/task-drag-indicator.c 2009-06-19 09:35:43 +0000
+++ applets/taskmanager/task-drag-indicator.c 2009-06-20 14:17:54 +0000
@@ -13,7 +13,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  *
- * Authored by Neil Jagdish Patel <email address hidden>
+ * Authored by Hannes Verschore <email address hidden>
  *
  */

====

Any particular reason why you removed Neil as author here (and applets/taskmanager/task-drag-indicator.h)?

In general, you should make sure that all of the code that you commented out (instead of deleted) should be annotated with the reason why you're commenting it.

review: Needs Information (superreview)

« Back to merge proposal