Merge lp:~gz/ubuntu/quantal/unity/apport_ppa_bug_tag_1029471 into lp:ubuntu/quantal/unity

[Martin Packman]

Change apport hook to use 'using-ppa' as the tag when reporting a bug against unity when the package doesn't come from the distro. This avoids a problem with version permitting characters such as tilde which are not valid in launchpad tags.

Of 1939 apport reported bugs against unity in ubuntu, there are 32 that have a version tag, and there are 26 different tags across those 32 bugs. This suggests to me that this isn't a useful classification. The version of the package, and the ppa which it came from, are already included in the metadata apport adds to the bug description, so no useful information is being lost.

[Didier Roche-Tolomelli (didrocks)]

as told on IRC:

didrocks | mgz: well, we do wait to have the version as it's enabling use to know when a regression started
didrocks | mgz: so I would rather like if you stop invalid characters, that we fix those in the version marshmalling
didrocks | we are really using that versionning for distro

review: Needs Fixing

[Martin Packman (gz)]

So, the version info is included in apport reports regardless.

Currently it's easy to find bugs provided you know the exact version of the ppa a bug was filed against, but you have to query all apport bugs (very slow) to discover which versions have bugs filed against them.

By using a general tag for all bugs filed against ppa versions of unity, it's easy to get specific versions, or a specific ppa, or a specific series, by filtering on the added information apport provides.

See <lp:~gz/+junk/unity-ppa-bugs> for an example script that lists current bugs, and could be used to update the current tags if required.

It would of course also be easy to mangle the version when used in a tag but given the small number of ppa filed bugs and that nearly all of them have a unique tag, I really don't think that's the neatest option.

[Dimitri John Ledkov (xnox)]

Crash database tracks when bugs appeared/disappeared, and there are scripts to parse launchpad duplicates as well.
Didrocks, can you reconsider this merge proposal?

[Dimitri John Ledkov (xnox)]

Crash-db only handles archive release versions?!

@ Marti gz
please change to include both tags: version & using-ppa.
When you do please, change the branch status to needs review again.

review: Needs Fixing

[Łukasz Zemczak (sil2100)]

I *personally* never used the version tag in an apport bug before, so for me it's +1. What I anyway was doing was looking at the description "Package:" part. I approve it in the form it is here. But we might want to wait for Didier to further comment on this issue maybe?

review: Approve

[Martin Packman (gz)]

We discussed this a little on IRC earlier today. Didier, can you take another look?

[Didier Roche-Tolomelli (didrocks)]

Martin: I would prefer that we have both (as launchpad has no easy way to query on a version and you have to cycle on every bug and watch for the description whereas a tag for a version enables to directly see which version was tested).

But I have nothing against adding another tag if you want, I would prefer that one to tell from which ppa (apt would tell from where it's coming) to know the source of it.

So still needing fixing IMHO.

review: Needs Fixing

Unmerged revisions

743. By Martin Packman on 2012-07-26

Make apport hook use tag using-ppa rather than version when unity comes from ppa

=== modified file 'debian/changelog'
--- debian/changelog	2012-07-20 05:23:20 +0000
+++ debian/changelog	2012-07-26 15:41:31 +0000
@@ -1,10 +1,16 @@
 unity (6.0.0-0ubuntu5) UNRELEASED; urgency=low
 
+  [ Łukasz 'sil2100' Zemczak ]
   * debian/rules:
     - added override for dh_shlibdeps to point it to the private directory of
       libunity-protocol-private.so
 
- -- Łukasz 'sil2100' Zemczak <[e-mail]>  Wed, 18 Jul 2012 12:50:15 +0200
+  [ Martin Packman ]
+  * debian/source_unity.py
+    - Make bug tag apport adds for packages from PPA generic rather than using
+      the version which may contain invalid characters (LP: #1029471)
+
+ -- Martin Packman <[e-mail]>  Thu, 26 Jul 2012 15:29:09 +0000
 
 unity (6.0.0-0ubuntu4) quantal; urgency=low
 

=== modified file 'debian/source_unity.py'
--- debian/source_unity.py	2012-07-02 13:02:47 +0000
+++ debian/source_unity.py	2012-07-26 15:41:31 +0000
@@ -6,13 +6,7 @@
     # for install from the ppa
     if not apport.packaging.is_distro_package(report['Package'].split()[0]):
         report['CrashDB'] = 'unity'
-        try:
-            version = packaging.get_version('unity')
-        except ValueError:
-            version = 'N/A'
-        if version is None:
-            version = 'N/A'
-        report['Tags'] += " rc-%s" % version
+        report['Tags'] += " using-ppa"
     
     # the crash is not in the unity code so reassign
     if "Stacktrace" in report and "/usr/lib/indicators" in report["Stacktrace"]: