Merge lp:~gz/pyjuju/os_client_use_version into lp:pyjuju

Proposed by Martin Packman
Status: Merged
Approved by: Clint Byrum
Approved revision: 584
Merged at revision: 584
Proposed branch: lp:~gz/pyjuju/os_client_use_version
Merge into: lp:pyjuju
Diff against target: 21 lines (+2/-2)
1 file modified
juju/providers/openstack/client.py (+2/-2)
To merge this branch: bzr merge lp:~gz/pyjuju/os_client_use_version
Reviewer Review Type Date Requested Status
Clint Byrum (community) Approve
Review via email: mp+127202@code.launchpad.net

Description of the change

Use real juju version in the Openstack UA string

Now juju's own version is recorded in the python package, the client
code in the openstack provider can get the version from there rather
than hard-coding '0.5'. This could potentially make debugging
regressions and the like easier in future.

To post a comment you must log in.
Revision history for this message
Martin Packman (gz) wrote :

Please take a look.

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

yes please!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'juju/providers/openstack/client.py'
2--- juju/providers/openstack/client.py 2012-09-26 04:56:39 +0000
3+++ juju/providers/openstack/client.py 2012-10-01 08:37:26 +0000
4@@ -39,6 +39,7 @@
5 from twisted.web.http_headers import Headers
6 from zope.interface import implements
7
8+import juju
9 from juju import errors
10
11 try:
12@@ -50,8 +51,7 @@
13 log = logging.getLogger("juju.openstack")
14
15
16-# Need the right juju version number, not exposed within python package.
17-_USER_AGENT = "juju/%s twisted/%s" % ("0.5", twisted.__version__)
18+_USER_AGENT = "juju/%s twisted/%s" % (juju.__version__, twisted.__version__)
19
20
21 class BytestringProducer(object):

Subscribers

People subscribed via source and target branches

to status/vote changes: