Merge lp:~gz/lp-dev-utils/smtp_authentication_prompt into lp:lp-dev-utils
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | 118 |
Merged at revision: | 119 |
Proposed branch: | lp:~gz/lp-dev-utils/smtp_authentication_prompt |
Merge into: | lp:lp-dev-utils |
Diff against target: |
48 lines (+15/-7) 1 file modified
ec2test/testrunner.py (+15/-7) |
To merge this branch: | bzr merge lp:~gz/lp-dev-utils/smtp_authentication_prompt |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+112291@code.launchpad.net |
Description of the change
At the moment ec2 land sends your local smtp configuration bazaar.conf to the instance and there is some logic for checking it looks sane, only the server is required. Technically smtp doesn't demand a username and password, but bzrlib.
This branch makes ec2test use the same logic locally as bzr uses, falling back to AuthenticationC
No tests, but I have run this locally and it prompted me for my password as expected.
[1]
23 + self.log("Careful, only connects from instance and a typo"
24 + " means no feedback from tests.\n")
I can guarantee that someone's going to complain about this being
opaque, so let's change it to:
"Enter your SMTP password carefully; if it's wrong the EC2 instance will
fail silently."