Merge lp:~gz/hydrazine/ask_write_private_access_only_643610 into lp:hydrazine

[Martin Packman]

Avoid some user confusion by only asking for "Change anything" access to launchpad, rather than giving them the option of shooting themselves in the foot by picking something else. It would be nice if there was way to not ask for full privileges all the time, but we have to work with what launchpadlib offers. As poolie says in the bug, the scripts in hydrazine run under direct command of the user and they can look at the source, so it's not too big of a worry.

[Vincent Ladeuil (vila)]

review: Approve

[Martin Pool (mbp)]

review: Approve

=== modified file 'hydrazine/__init__.py'
--- hydrazine/__init__.py	2011-04-06 04:02:04 +0000
+++ hydrazine/__init__.py	2011-10-09 00:18:24 +0000
@@ -30,6 +30,18 @@
     #
     # NB: Generally naming the parameters seems safer, but in this case the
     # first changed from 'consumer_name' to 'application_name' in natty.
+    #
+    # Specify WRITE_PRIVATE access so the user doesn't get a confusing list of
+    # options then a strange HTTP error later if they picked read-only. See:
+    #
+    # <http://pad.lv/643610>
+    # <http://jameswestby.net/weblog/tech/16-Improving-the-usability-of-launchpadlib-using-code.html>
+    #
+    # Unfortunately launchpadlib doesn't detect if existing credentials have
+    # insufficient access so we can't ask for lesser permissions then upgrade
+    # as required later. As hydrazine runs under direct control of the user,
+    # always having the ability to change everything isn't too bad.
     return Launchpad.login_with(
         'hydrazine',
+        allow_access_levels=['WRITE_PRIVATE'],
         service_root=LPNET_SERVICE_ROOT)