Merge lp:~gz/bzr/unexpected_successes_are_bad_654474 into lp:bzr
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Andrew Bennetts | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 5888 | ||||
Proposed branch: | lp:~gz/bzr/unexpected_successes_are_bad_654474 | ||||
Merge into: | lp:bzr | ||||
Diff against target: |
146 lines (+67/-12) 4 files modified
bzrlib/tests/__init__.py (+26/-0) bzrlib/tests/per_workingtree/test_smart_add.py (+20/-12) bzrlib/tests/test_selftest.py (+18/-0) doc/en/release-notes/bzr-2.4.txt (+3/-0) |
||||
To merge this branch: | bzr merge lp:~gz/bzr/unexpected_successes_are_bad_654474 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Bennetts | Approve | ||
Review via email: mp+61147@code.launchpad.net |
Commit message
Make test unexpected successes count as failures
Description of the change
Recently a few people have run into a mysterious "FAILED ()" selftest result with no errors reported. This is from using testtools/subunit versions with bug 654474 fixed, and a couple of long-standing unexpected successes in the bzrlib test suite now count as the run failing, but don't give any output.
I did a quick poll about bumping the minimum version of testtools (again), but this branch gets the basics of the handling right without needing that step yet. So, for now they count as and are reported similar to straight failures.
One annoyance is I should really test VerboseTestResu
Docstring pedantry:
8 + def addUnexpectedSu ccess(self, test, details=None):
9 + """Tell result the test unexpectedly passed, counting as a failure
That sentence should end in a period.
I've chatted IRL about the test_smart_add changes, I think I may have a nicer alternative that; I'll put up a branch in a moment.