Merge lp:~gz/bzr/trivial_mac_insensitive_glob into lp:bzr
Proposed by
Martin Packman
Status: | Merged |
---|---|
Approved by: | Vincent Ladeuil |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5562 |
Proposed branch: | lp:~gz/bzr/trivial_mac_insensitive_glob |
Merge into: | lp:bzr |
Diff against target: |
22 lines (+4/-2) 1 file modified
bzrlib/tests/test_win32utils.py (+4/-2) |
To merge this branch: | bzr merge lp:~gz/bzr/trivial_mac_insensitive_glob |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincent Ladeuil | Approve | ||
John A Meinel | Approve | ||
Review via email:
|
Commit message
Skip win32utils case insensitive globbing tests on OS X
Description of the change
Refine the skip condition of a couple of win32utils tests so OSX isn't surprised when it runs them and they don't work. In practice, these tests require not only an case-insensitive filesystem, but beyond that working support in os.path itself.
I've not made this into a new feature because something that comes up in one file only isn't refined enough to make into an api, especially when the current check is depending on implementation details of several standard library modules. Nevertheless, it's more accurate than the current.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/7/2010 11:45 AM, Martin [gz] wrote: /bugs.launchpad .net/bugs/ 686595
> Martin [gz] has proposed merging lp:~gz/bzr/trivial_mac_insensitive_glob into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #686595 Windows-specific case insensitive globbing tests fail on Mac OSX
> https:/
>
>
> Refine the skip condition of a couple of win32utils tests so OSX isn't surprised when it runs them and they don't work. In practice, these tests require not only an case-insensitive filesystem, but beyond that working support in os.path itself.
>
> I've not made this into a new feature because something that comes up in one file only isn't refined enough to make into an api, especially when the current check is depending on implementation details of several standard library modules. Nevertheless, it's more accurate than the current.
review: approve
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
+0JMACgkQJdeBCY SNAAMLhgCgtDFCT 4Fr1DHWBmYUJWhQ nsJ9 PdiByd2nNlo5L/ fB9
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkz
EhoAoNIECpstAzk
=byqi
-----END PGP SIGNATURE-----