-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 9/5/2011 6:58 PM, Martin [gz] wrote:
>> I'm pretty hesitant to change the required number of char to 4,
>> but it may be correct.
> 
> Yeah, I was also very unsure about that. I think it's okay
> because:
> 
> * It was throwing IndexError, so throwing a more appropriate error
> is progress * _win32_local_path_from_url already treats
> 'file:///C:' as invalid and has a test * Explorer doesn't resolve a
> file url without a trailing slash for me

This is what I'm getting with bzr.dev after your patch landed, trying
to run "bzr st" outside of a working tree. Thoughts?

$ bzr --version
Bazaar (bzr) 2.5.0dev1
  from bzr checkout C:/dev/bzr/bzr.dev
    revision: 6125
    revid: <email address hidden>
    branch nick: bzr
...

$ bzr st
bzr: ERROR: exceptions.IndexError: string index out of range

Traceback (most recent call last):
  File "C:\dev\bzr\bzr.dev\bzrlib\commands.py", line 918, in
exception_to_return_code
    return the_callable(*args, **kwargs)
  File "C:\dev\bzr\bzr.dev\bzrlib\commands.py", line 1118, in run_bzr
    ret = run(*run_argv)
  File "C:\dev\bzr\bzr.dev\bzrlib\commands.py", line 676, in
run_argv_aliases
    return self.run(**all_cmd_args)
  File "C:\dev\bzr\bzr.dev\bzrlib\commands.py", line 698, in run
    return self._operation.run_simple(*args, **kwargs)
  File "C:\dev\bzr\bzr.dev\bzrlib\cleanup.py", line 135, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "C:\dev\bzr\bzr.dev\bzrlib\cleanup.py", line 165, in
_do_with_cleanups
    result = func(*args, **kwargs)
  File "C:\dev\bzr\bzr.dev\bzrlib\commands.py", line 1133, in ignore_pipe
    result = func(*args, **kwargs)
  File "C:\dev\bzr\bzr.dev\bzrlib\builtins.py", line 294, in run
    tree, relfile_list = WorkingTree.open_containing_paths(file_list)
  File "C:\dev\bzr\bzr.dev\bzrlib\workingtree.py", line 296, in
open_containing_paths
    tree = WorkingTree.open_containing(default_directory)[0]
  File "C:\dev\bzr\bzr.dev\bzrlib\workingtree.py", line 279, in
open_containing
    control, relpath = bzrdir.BzrDir.open_containing(path)
  File "C:\dev\bzr\bzr.dev\bzrlib\bzrdir.py", line 875, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "C:\dev\bzr\bzr.dev\bzrlib\bzrdir.py", line 901, in
open_containing_from_transport
    new_t = a_transport.clone('..')
  File "C:\dev\bzr\bzr.dev\bzrlib\transport\local.py", line 92, in clone
    return LocalTransport(abspath)
  File "C:\dev\bzr\bzr.dev\bzrlib\transport\local.py", line 73, in
__init__
    super(LocalTransport, self).__init__(base)
  File "C:\dev\bzr\bzr.dev\bzrlib\transport\__init__.py", line 314, in
__init__
    base.rstrip("/"))[1]
  File "C:\dev\bzr\bzr.dev\bzrlib\urlutils.py", line 458, in
split_segment_parameters
    (base_url, subsegments) = split_segment_parameters_raw(url)
  File "C:\dev\bzr\bzr.dev\bzrlib\urlutils.py", line 445, in
split_segment_parameters_raw
    (parent_url, child_dir) = split(url)
  File "C:\dev\bzr\bzr.dev\bzrlib\urlutils.py", line 430, in split
    url_base, path = _win32_extract_drive_letter(url_base, path)
  File "C:\dev\bzr\bzr.dev\bzrlib\urlutils.py", line 391, in
_win32_extract_drive_letter
    if len(path) < 3 or path[2] not in ':|' or path[3] != '/':
IndexError: string index out of range

bzr 2.5.0dev1 on python 2.6.6 (Windows-Vista-6.0.6002-SP2)
arguments: ['C:/dev/bzr/bzr.dev/bzr', 'st']
plugins: bash_completion[2.5.0dev1], bzrtools[2.4.0],
    changelog_merge[2.5.0dev1], colo[0.2.1dev], dummy_request[unknown],
    dump[unknown], email[unknown], explorer[1.2.1], fastimport[0.11.0dev],
    file_locking[0.1.0dev], gimmepdb[unknown], grep[0.2.0],
    history_db[unknown], in_ancestry[unknown], launchpad[2.5.0dev1],
    lock_test[0.1.0dev], loggerhead[1.18.0],
    netrc_credential_store[2.5.0dev1], news_merge[2.5.0dev1],
    per_file_graph[unknown], pqm[1.4.0dev], pybloom[unknown],
qbzr[0.22.0dev],
    register[unknown], repodebug[unknown], repodetails[1.9.0dev],
    rewrite[0.7.0dev], search[1.7.0dev], start[unknown], stats[0.1.0dev],
    test_groupcompress[unknown], time_iter_changes[unknown],
    track_wow_renames[0.0.1dev], vimdiff[unknown], weave_fmt[2.5.0dev1]
encoding: 'cp1252', fsenc: 'mbcs', lang: 'C.UTF-8'

*** Bazaar has encountered an internal error.  This probably indicates a
    bug in Bazaar.  You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEUEARECAAYFAk5wrUcACgkQJdeBCYSNAAMIZwCXa/MDG7He4InF2ChUywIR9K3l
uwCcDdGCJzS0vh6IjyyOSNqErR/Bqy8=
=cF5F
-----END PGP SIGNATURE-----