Merge lp:~gz/bzr/require_testtools_0.9.5_for_selftest into lp:bzr

Proposed by Martin Packman
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: no longer in the source branch.
Merged at revision: 5550
Proposed branch: lp:~gz/bzr/require_testtools_0.9.5_for_selftest
Merge into: lp:bzr
Diff against target: 29 lines (+6/-2)
2 files modified
bzrlib/tests/__init__.py (+2/-2)
doc/en/release-notes/bzr-2.3.txt (+4/-0)
To merge this branch: bzr merge lp:~gz/bzr/require_testtools_0.9.5_for_selftest
Reviewer Review Type Date Requested Status
Vincent Ladeuil Needs Information
Review via email: mp+35144@code.launchpad.net

Commit message

Change minimum required testtools version for selftest to 0.9.5 for unicode fixes

Description of the change

Had hoped to put this off for a little longer, as testtools 0.9.5 was only released at the end of July, but the test in lp:~gz/bzr/escape_selftest_console_output_633216 depends on fixed unicode support.

Why 0.9.5? The changes that allow testtools to work with non-ascii details (tracebacks, logs), were merged for 0.9.4, and 0.9.5 has some fixes for related fallout.

PQM may need its testtools package updating in order for this branch to land.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

I've filed rt #41340 asking for testtools-0.9.6 to installed in the bzr.dev pqm chroot.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Marking as Needs Information until pqm is updated, this doesn't apply to the patch but makes
the pp job easier.

review: Needs Information
Revision history for this message
Martin Packman (gz) wrote :

Have merged trunk and PQM has been upgraded so this should be now landable.

Revision history for this message
Martin Packman (gz) wrote :

sent to pqm by email

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/tests/__init__.py'
2--- bzrlib/tests/__init__.py 2010-10-18 17:06:37 +0000
3+++ bzrlib/tests/__init__.py 2010-11-19 23:01:59 +0000
4@@ -55,8 +55,8 @@
5 import testtools
6 # nb: check this before importing anything else from within it
7 _testtools_version = getattr(testtools, '__version__', ())
8-if _testtools_version < (0, 9, 2):
9- raise ImportError("need at least testtools 0.9.2: %s is %r"
10+if _testtools_version < (0, 9, 5):
11+ raise ImportError("need at least testtools 0.9.5: %s is %r"
12 % (testtools.__file__, _testtools_version))
13 from testtools import content
14
15
16=== modified file 'doc/en/release-notes/bzr-2.3.txt'
17--- doc/en/release-notes/bzr-2.3.txt 2010-11-18 19:38:28 +0000
18+++ doc/en/release-notes/bzr-2.3.txt 2010-11-19 23:01:59 +0000
19@@ -103,6 +103,10 @@
20 Instead, use '...' as a wildcard if you don't care about the output.
21 (Martin Pool, #637830)
22
23+* Bump minimum testtools version required to run ``bzr selftest`` from 0.9.2
24+ to 0.9.5 which will allow tests that need the fixed unicode handling to be
25+ written. (Martin [gz])
26+
27
28 bzr 2.3b3
29 #########