Merge lp:~gz/bzr/https_proxy_host_matching_944696 into lp:bzr/2.5
Proposed by
Martin Packman
Status: | Merged |
---|---|
Approved by: | Martin Packman |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6491 |
Proposed branch: | lp:~gz/bzr/https_proxy_host_matching_944696 |
Merge into: | lp:bzr/2.5 |
Diff against target: |
41 lines (+10/-3) 2 files modified
bzrlib/transport/http/_urllib2_wrappers.py (+6/-3) doc/en/release-notes/bzr-2.5.txt (+4/-0) |
To merge this branch: | bzr merge lp:~gz/bzr/https_proxy_host_matching_944696 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | Approve | ||
Review via email: mp+96803@code.launchpad.net |
Commit message
Use correct host name for checking certificates when using a proxy for https
Description of the change
Fixes the issue of checking against the wrong host when tunnelling https through an http proxy. The proxied_host attribute contains the right thing in that case, it just wants the port taken off.
Any ideas on unit testing this? I've confirmed it works per my reproduction steps in the bug.
To post a comment you must log in.
This looks good. I think this needs a release notes entry.
I'm not sure what the best way is to test this either. Ideally we'd set up an actual proxy, but you mentioned on IRC that it's hard to do with twisted's servers?