Code review comment for lp:~gz/bzr/add_two_in_unicode_cwd_686611

Revision history for this message
Vincent Ladeuil (vila) wrote :

Since only windows is concerned here (as far as regressions go), I'd prefer that you target 2.2 instead. We won't release 2.0 and 2.1 for windows any more so no need to make our life harder when merging up.

For the news entry, just file it where appropriate in NEWS in the 2.2 branch. When merging up in trunk, don't duplicate the entry for 2.3 but make sure it's added to doc/en/releases-notes/bzr-2.2.txt (the merge should try to add it to bzr-2.3.txt with huge conflicts, just get rid of them).

The fix looks sane enough that I can pre-approve landing it to 2.2 and trunk, but feel free to make two proposals (one for 2.2 and one for trunk) if you prefer a further review.

So my vote is Disapprove for 2.0, but Approve for 2.2 and trunk

review: Disapprove

« Back to merge proposal