Merge lp:~gz/bzr-pipeline/no_launchpadlib_needed_601466 into lp:bzr-pipeline

Proposed by Martin Packman
Status: Rejected
Rejected by: Aaron Bentley
Proposed branch: lp:~gz/bzr-pipeline/no_launchpadlib_needed_601466
Merge into: lp:bzr-pipeline
Diff against target: 21 lines (+2/-2)
1 file modified
__init__.py (+2/-2)
To merge this branch: bzr merge lp:~gz/bzr-pipeline/no_launchpadlib_needed_601466
Reviewer Review Type Date Requested Status
Aaron Bentley Pending
Review via email: mp+29156@code.launchpad.net

Description of the change

Removes the dependency on launchpadlib, for real this time. Adds to the fix attempted in r170 work by catching the correct exception.

To post a comment you must log in.

Unmerged revisions

173. By Martin Packman

Remove need for launchpadlib to be installed by catching bzrlib.errors.DependencyNotPresent

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '__init__.py'
2--- __init__.py 2010-04-24 04:37:09 +0000
3+++ __init__.py 2010-07-03 21:13:25 +0000
4@@ -106,7 +106,7 @@
5
6
7 import bzrlib
8-from bzrlib import api
9+from bzrlib import api, errors
10 from bzrlib.commands import plugin_cmds
11 from bzrlib.directory_service import AliasDirectory, directories
12
13@@ -160,7 +160,7 @@
14 try:
15 from bzrlib.plugins.launchpad import lp_api
16 from bzrlib.plugins.launchpad import lp_propose
17-except ImportError:
18+except (ImportError, errors.DependencyNotPresent):
19 pass
20 else:
21 def get_prerequisite_from_pipe(hook_params):

Subscribers

People subscribed via source and target branches