Merge lp:~gz/brz/buffer_to_memoryview into lp:brz
Proposed by
Martin Packman
Status: | Merged |
---|---|
Approved by: | Jelmer Vernooij |
Approved revision: | no longer in the source branch. |
Merge reported by: | The Breezy Bot |
Merged at revision: | not available |
Proposed branch: | lp:~gz/brz/buffer_to_memoryview |
Merge into: | lp:brz |
Diff against target: |
195 lines (+59/-25) 4 files modified
breezy/osutils.py (+6/-5) breezy/tests/file_utils.py (+1/-1) breezy/tests/test_osutils.py (+16/-14) breezy/transport/sftp.py (+36/-5) |
To merge this branch: | bzr merge lp:~gz/brz/buffer_to_memoryview |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij | Approve | ||
Review via email: mp+324573@code.launchpad.net |
Commit message
Use memoryview over buffer for compatibility
Description of the change
The 'buffer' 2to3 fixer was especially unhelpful here, creating invalid code. Pretty simple to adapt our uses though.
Branch also makes the classes TestSendAll, TestPumpFile, and TestPumpStringFile pass on Python 3.
To post a comment you must log in.
Running landing tests failed 10.242. 247.184: 8080/job/ brz-dev/ 4/
http://