Merge lp:~gustav-hartvigsson/bzr-gtk/fix-viz into lp:bzr-gtk

Proposed by Gustav Hartvigsson on 2014-11-25
Status: Needs review
Proposed branch: lp:~gustav-hartvigsson/bzr-gtk/fix-viz
Merge into: lp:bzr-gtk
Diff against target: 15 lines (+0/-6)
1 file modified
viz/branchwin.py (+0/-6)
To merge this branch: bzr merge lp:~gustav-hartvigsson/bzr-gtk/fix-viz
Reviewer Review Type Date Requested Status
Richard Wilbur 2014-11-25 Needs Information on 2014-12-19
Review via email: mp+242795@code.launchpad.net

Description of the change

This fixes a long standing issue with the with gtk-bzr's viz util.
The problem was that the GtkAlign was taking too much space because
of the custom allocation of space.

The problem was found using the GtkIntspector.

To post a comment you must log in.
Richard Wilbur (richard-wilbur) wrote :

Has this long-standing issue with bzr-gtk's viz utility been documented with a bug filed in Launchpad? If so, please mention the bug number in the "Description of the Change". If no bug has been filed for this problem, please file one.

review: Needs Information

Unmerged revisions

797. By Gustav Hartvigsson on 2014-11-25

* Fixed bzr-gtk's viz util, using the new Gtk Inspector.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'viz/branchwin.py'
2--- viz/branchwin.py 2012-03-01 21:29:00 +0000
3+++ viz/branchwin.py 2014-11-25 15:36:24 +0000
4@@ -336,12 +336,6 @@
5 align.add(self.treeview)
6 # user-configured size
7 size = self._load_size('viz-graph-size')
8- if size:
9- width, height = size
10- align.set_size_request(width, height)
11- else:
12- (width, height) = self.get_size()
13- align.set_size_request(width, int(height / 2.5))
14 self._save_size_on_destroy(align, 'viz-graph-size')
15 align.show()
16

Subscribers

People subscribed via source and target branches

to all changes: