Merge ~guoqiao/charm-prometheus-ceph-exporter:update-README into charm-prometheus-ceph-exporter:master

Proposed by Joe Guo
Status: Merged
Approved by: James Troup
Approved revision: bd74806979e65a78154b27e74008a18877e43f13
Merged at revision: dff1ad8c3054045b97ef9b2282c3a3108be3a0d8
Proposed branch: ~guoqiao/charm-prometheus-ceph-exporter:update-README
Merge into: charm-prometheus-ceph-exporter:master
Diff against target: 16 lines (+5/-0)
1 file modified
src/README.md (+5/-0)
Reviewer Review Type Date Requested Status
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
BootStack Reviewers Pending
BootStack Reviewers Pending
Review via email: mp+415357@code.launchpad.net

Commit message

Add deprecated notice in README for ceph >= Nautilus

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Joe Guo (guoqiao) wrote :

For bug LP#1931745, our original plan was to block prometheus-ceph-exporter if ceph >= Nautilus.

However, the effect to retrieve ceph version in p-c-e charm is more than it's worth, we have to create patches in following 3 repos to reach the goal:

https://review.opendev.org/c/openstack/charm-ceph-mon/+/805600
https://review.opendev.org/c/openstack/charm-interface-ceph-client/+/805582
https://code.launchpad.net/~ziyiwang/charm-prometheus-ceph-exporter/+git/charm-prometheus-ceph-exporter/+merge/407378

Also, we got questions and resistance from upstream team about:
- why we need to send ceph version over relation ? (we don't have better solution to get ceph version)
- why we don't have functional tests for this feature ? (3 repos are involved, we can not add func test when related changes are not in place yet)

The best place to add func test is in this charm itself when the other 2 patches are merged. However, this charm is going to be deprecated, so it's not worthy, again.

After discussion with elmo and Andrea, the decision is to add deprecated message in README of this charm, and drop above patches.

Review appreciated.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision dff1ad8c3054045b97ef9b2282c3a3108be3a0d8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/README.md b/src/README.md
2index 50d92e8..eb29076 100644
3--- a/src/README.md
4+++ b/src/README.md
5@@ -2,6 +2,11 @@
6
7 This charm provides the [Prometheus Ceph exporter](https://github.com/digitalocean/ceph_exporter), part of the [Prometheus](https://prometheus.io/) monitoring system
8
9+# IMPORTANT NOTICE
10+
11+This charm is deprecated since ceph Nautilus (14.0.0+), please use [charm-ceph-dashbaord](https://opendev.org/openstack/charm-ceph-dashboard) instead.
12+Otherwise you will run into bug [LP#1931745](https://bugs.launchpad.net/charm-prometheus-ceph-exporter/+bug/1931745).
13+
14 # Introduction and Preparation
15
16 The charm implements ceph-exporter functionality for Prometheus, it consumes the prometheus-ceph-exporter snap package,

Subscribers

People subscribed via source and target branches

to all changes: