Merge lp:~gue5t/midori/window-state-event into lp:midori

[gue5t gue5t]

Use correct signature for window-state-event handler

Change the signal handler to return a gboolean as it should. This change results in correct maximize/unmaximize with GTK3 CSD.

[Danielle Foré (danrabbit)]

Hm, for both Cody and I this branch makes decorations not show at all for maximized windows.

[gue5t gue5t (gue5t)]

> Hm, for both Cody and I this branch makes decorations not show at all for
> maximized windows.

I don't like it, personally, but that's what Midori has been doing all along, via midori-browser.c:5837: "gtk_window_set_hide_titlebar_when_maximized (GTK_WINDOW (browser), TRUE);"

[Danielle Foré (danrabbit)]

Do you know if there's a reasoning behind that? I feel like if the DE wanted to hide decorations for maximized windows that the WM would take care of that.

[Cris Dywan (kalikiana)]

The setting tells the WM that it's safe to hide the title and it doesn't contain vital pieces of information ie. wastes space by being there if it's maximized anyway.

I suppose the flaw here is that it's not just an indication but GTK+ itself does something in the backend.

[Danielle Foré (danrabbit)]

Yeah right now basically what we're looking at is that maximized decorations in elementary are either broken or not there at all, which isn't very ideal :p

What's the use case for this? Can we if/def this to whatever desktop environment it's supposed to support? I don't know of any other application that has this behavior.

[Cris Dywan (kalikiana)]

Correction, internally _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED will be set by GTK+ on X11, Gala and Mutter handle that property, not sure about WM's. So the bug is on the WM side.

Incidentally the patch is correct, it didn't add the behavior either.

review: Approve

=== modified file 'midori/midori-browser.c'
--- midori/midori-browser.c	2014-06-05 10:35:56 +0000
+++ midori/midori-browser.c	2014-07-11 09:09:44 +0000
@@ -5451,7 +5451,7 @@
     }
 }
 
-static void
+static gboolean
 midori_browser_window_state_event_cb (MidoriBrowser*       browser,
                                       GdkEventWindowState* event)
 {
@@ -5463,6 +5463,8 @@
     else if (event->new_window_state & GDK_WINDOW_STATE_FULLSCREEN)
         window_state = MIDORI_WINDOW_FULLSCREEN;
     g_object_set (browser->settings, "last-window-state", window_state, NULL);
+
+    return FALSE;
 }
 
 static gboolean