Midori Web Browser

Merge lp:~gue5t/midori/tabby-sorting-type into lp:midori

  1. tabby-sorting-type
  2. Merge into trunk
Proposed by gue5t gue5t
Status: Merged
Approved by: Cris Dywan
Approved revision: 6938
Merged at revision: 6941
Proposed branch: lp:~gue5t/midori/tabby-sorting-type
Merge into: lp:midori
Diff against target: 12 lines (+1/-1)
1 file modified
extensions/tabby.vala (+1/-1)
To merge this branch: bzr merge lp:~gue5t/midori/tabby-sorting-type
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+256757@code.launchpad.net

Commit message

fix incorrect type of MAX(sorting) in Tabby

Description of the change

Tabby was using the "get_int64" to obtain sorting when the sorting column in the db is a double. This corrects the type to the one used elsewhere in the code.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Very nice catch. Thank you!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/tabby.vala'
2--- extensions/tabby.vala 2014-04-25 19:49:26 +0000
3+++ extensions/tabby.vala 2015-04-19 14:50:04 +0000
4@@ -558,7 +558,7 @@
5 ":session_id", typeof (int64), this.id);
6 statement.step ();
7 double sorting;
8- string? sorting_string = statement.get_int64 ("MAX(sorting)").to_string ();
9+ string? sorting_string = statement.get_double ("MAX(sorting)").to_string ();
10 if (sorting_string != null) {
11 /* we have to use a seperate if condition to avoid
12 a `possibly unassigned local variable` error */

Subscribers

People subscribed via source and target branches

to all changes: