Midori Web Browser

Merge lp:~gue5t/midori/fix-keyup into lp:midori

  1. fix-keyup
  2. Merge into trunk
Proposed by gue5t gue5t
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6840
Merged at revision: 6840
Proposed branch: lp:~gue5t/midori/fix-keyup
Merge into: lp:midori
Diff against target: 12 lines (+1/-1)
1 file modified
midori/midori-browser.c (+1/-1)
To merge this branch: bzr merge lp:~gue5t/midori/fix-keyup
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+242568@code.launchpad.net

Commit message

fix JavaScript keyup event by calling inherited key-release-event handler in MidoriBrowser

Description of the change

Fix javascript keyup. With the addition of a handler to snoop shift-key presses/releases, we had mistakenly prevented MidoriBrowser's inherited key-release-event handler from running. This introduces the call and restores proper behavior.

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) wrote :

Fixes the issue. Does not seem to introduce regressions from the mild testing

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-browser.c'
2--- midori/midori-browser.c 2014-11-18 21:16:55 +0000
3+++ midori/midori-browser.c 2014-11-22 17:30:04 +0000
4@@ -2042,7 +2042,7 @@
5 GdkEventKey* event)
6 {
7 _update_reload_tooltip (widget, event, TRUE);
8- return FALSE;
9+ return GTK_WIDGET_CLASS (midori_browser_parent_class)->key_release_event (widget, event);
10 }
11
12 static gboolean

Subscribers

People subscribed via source and target branches

to all changes: