Midori Web Browser

Merge lp:~gue5t/midori/apps-mousebutton into lp:midori

  1. apps-mousebutton
  2. Merge into trunk
Proposed by gue5t gue5t
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6893
Merged at revision: 6893
Proposed branch: lp:~gue5t/midori/apps-mousebutton
Merge into: lp:midori
Diff against target: 21 lines (+3/-1)
1 file modified
extensions/apps.vala (+3/-1)
To merge this branch: bzr merge lp:~gue5t/midori/apps-mousebutton
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+253069@code.launchpad.net

Commit message

Only remove apps in the sidepanel when left-clicking the delete icon

Description of the change

Opening the "applications" sidepanel pane shows the existing apps, with a delete button next to each. Right-clicking the delete button results in deleting the app, which is unexpected. This branch changes the delete button to require a left mouse button click.

Also fixes a typo: "independant" -> "independent"

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/apps.vala'
2--- extensions/apps.vala 2014-03-29 21:26:13 +0000
3+++ extensions/apps.vala 2015-03-16 15:48:41 +0000
4@@ -209,7 +209,7 @@
5 /* FIXME: Profiles are broken on win32 because of no multi instance support */
6 var profile = new Gtk.ToolButton.from_stock (Gtk.STOCK_ADD);
7 profile.label = _("New _Profile");
8- profile.tooltip_text = _("Creates a new, independant profile and a launcher");
9+ profile.tooltip_text = _("Creates a new, independent profile and a launcher");
10 profile.use_underline = true;
11 profile.is_important = true;
12 profile.show ();
13@@ -254,6 +254,8 @@
14 bool button_released (Gdk.EventButton event) {
15 Gtk.TreePath? path;
16 Gtk.TreeViewColumn column;
17+ if (event.button != 1)
18+ return false;
19 if (treeview.get_path_at_pos ((int)event.x, (int)event.y, out path, out column, null, null)) {
20 if (path != null) {
21 if (column == treeview.get_column (2)) {

Subscribers

People subscribed via source and target branches

to all changes: