Merge lp:~gtg-user/gtg/haseeb_gtg into lp:~gtg/gtg/old-trunk

Proposed by Abdul Rauf on 2012-08-14
Status: Rejected
Rejected by: Izidor Matušov on 2012-11-11
Proposed branch: lp:~gtg-user/gtg/haseeb_gtg
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 12 lines (+1/-1)
1 file modified
GTG/gtk/editor/editor.py (+1/-1)
To merge this branch: bzr merge lp:~gtg-user/gtg/haseeb_gtg
Reviewer Review Type Date Requested Status
Izidor Matušov 2012-08-14 Disapprove on 2012-11-11
Review via email: mp+119599@code.launchpad.net

Commit message

debugged Bug #1032745 Hidden part of calendar

Description of the change

debugged Bug #1032745 Hidden part of calendar

To post a comment you must log in.
Izidor Matušov (izidor) wrote :

Hi, thanks for your fix, but it don't work when I have a part of the window outside of the screen: http://i.imgur.com/CLmx1.png Please, fix it.

The similar glitch happens on the other side of the screen as well. http://i.imgur.com/Uf3Gf.png

Please, describe your changes in your commit message. (replace the text "my local commit" with the actual description of your changes)

To solve this problem you will need information about the screen: class gtk.gdk.Screen -- http://www.pygtk.org/docs/pygtk/class-gdkscreen.html

review: Needs Fixing (code, running)
Abdul Rauf (haseeb) wrote :

> Hi, thanks for your fix, but it don't work when I have a part of the window
> outside of the screen: http://i.imgur.com/CLmx1.png Please, fix it.
>
> The similar glitch happens on the other side of the screen as well.
> http://i.imgur.com/Uf3Gf.png
>
> Please, describe your changes in your commit message. (replace the text "my
> local commit" with the actual description of your changes)
>
> To solve this problem you will need information about the screen: class
> gtk.gdk.Screen -- http://www.pygtk.org/docs/pygtk/class-gdkscreen.html
Hi izidor
 it is working perfect for me, may be should i test it on ubuntu?

below are the screen shots

http://i.imgur.com/XENK3.png

http://i.imgur.com/PiUOz.png

Izidor Matušov (izidor) wrote :

Try to push the window more to the left that part of the window is not in the screen. It is an extreme use case, but it should be solved. The same thing on the right side of the screen.

review: Needs Fixing
Izidor Matušov (izidor) wrote :

Disapproving this patch because it is just a one-liner, nobody works on it, and it doesn't solve the problem.

review: Disapprove

Unmerged revisions

1227. By Abdul Rauf on 2012-08-13

my local commit

1226. By Abdul Rauf on 2012-08-13

my local commit

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GTG/gtk/editor/editor.py'
2--- GTG/gtk/editor/editor.py 2012-08-08 14:56:18 +0000
3+++ GTG/gtk/editor/editor.py 2012-08-14 17:59:20 +0000
4@@ -388,7 +388,7 @@
5 #we show the calendar at the right position
6 rect = widget.get_allocation()
7 x, y = widget.window.get_origin()
8- self.calendar.show_at_position(x + rect.x + rect.width,
9+ self.calendar.show_at_position(x + rect.x + rect.width + rect.width,
10 y + rect.y)
11
12 def on_date_changed(self, calendar):

Subscribers

People subscribed via source and target branches

to status/vote changes: