GTG

Merge lp:~gtg-user/gtg/bugfix-493335 into lp:~gtg/gtg/old-trunk

Proposed by Alan Gomes Alvino
Status: Rejected
Rejected by: Izidor Matušov
Proposed branch: lp:~gtg-user/gtg/bugfix-493335
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 15 lines (+5/-0)
1 file modified
GTG/gtk/editor/taskview.py (+5/-0)
To merge this branch: bzr merge lp:~gtg-user/gtg/bugfix-493335
Reviewer Review Type Date Requested Status
Izidor Matušov Disapprove
Bertrand Rousseau (community) Needs Information
Review via email: mp+113499@code.launchpad.net

Description of the change

The bug is because the delete_range is call after the delete_selection, and the delete_seletcion doesn't remove the arrow. What i do was after the delete_range i remove the arrow.

To post a comment you must log in.
Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Do you need to both disconnect the delete-range signal and ask the buffer to stop the emission of this signal? Isn't that enough to just stop the emission of the signal?

review: Needs Information
Revision history for this message
Izidor Matušov (izidor) wrote :

Closing because of inactivity

review: Disapprove

Unmerged revisions

1200. By Alan Gomes <email address hidden>

Fixed delete bug

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GTG/gtk/editor/taskview.py'
2--- GTG/gtk/editor/taskview.py 2012-05-20 19:05:20 +0000
3+++ GTG/gtk/editor/taskview.py 2012-07-05 07:10:24 +0000
4@@ -797,6 +797,11 @@
5 it.forward_char()
6 #now we really delete the selected stuffs
7 selec = self.buff.get_selection_bounds()
8+ # Delete what not being deleted by delete_selection, the ideal is run _delete_range before the delete_selection
9+ self.buff.disconnect(self.delete_sigid)
10+ self.buff.stop_emission("delete-range")
11+ self.buff.delete(start, end)
12+ self.delete_sigid = self.buff.connect("delete-range", self._delete_range)
13 # if selec:
14 # print "deleted text is ##%s##" %self.buff.get_text(selec[0], selec[1])#(start, end)
15 # self.buff.disconnect(self.delete_sigid)

Subscribers

People subscribed via source and target branches

to status/vote changes: