Merge lp:~gtg-user/gtg/bugfix-1001962 into lp:~gtg/gtg/old-trunk

Proposed by Alan Gomes Alvino on 2012-06-21
Status: Rejected
Rejected by: Izidor Matušov on 2012-06-21
Proposed branch: lp:~gtg-user/gtg/bugfix-1001962
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 29 lines (+8/-2)
2 files modified
CHANGELOG (+1/-0)
GTG/gtk/editor/taskview.py (+7/-2)
To merge this branch: bzr merge lp:~gtg-user/gtg/bugfix-1001962
Reviewer Review Type Date Requested Status
Izidor Matušov Disapprove on 2012-06-21
Lionel Dricot (community) 2012-06-21 Disapprove on 2012-06-21
Review via email: mp+111329@code.launchpad.net

Description of the change

When create a tag after every word pressed the taskwiew added a word to the tag_list, what i do was read the last char and verify if it's a 'space'(blank). If is a 'space' the tag is added, if not the tag is not added. A problem in this solution is that the mark of the tag just will be showed after the space.

To post a comment you must log in.

There are multiple problems in this solution:

1) A tag could be followed by many characters, not only a space
2) A tag could be followed by the end of the text

But, more importantly, this doesn't solve the root cause of the bug which is that a tag with 0 tasks is not removed from the sidebar. That's where the real bug is.

review: Disapprove
Izidor Matušov (izidor) wrote :

This bug should be solved in LibLarch. As Lionel said, your solution is a workaround and doesn't solve the reason of this bug.

review: Disapprove

Unmerged revisions

1199. By Alan Gomes <email address hidden> on 2012-06-21

Changelog changed

1198. By Alan Gomes <email address hidden> on 2012-06-20

Fix the bug getting the forward char of the end of word and checking if is space

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CHANGELOG'
2--- CHANGELOG 2012-06-09 12:25:03 +0000
3+++ CHANGELOG 2012-06-21 03:19:18 +0000
4@@ -1,4 +1,5 @@
5 2012-0?-?? Getting Things GNOME! 0.3
6+ * Fix the insert tag menu #1001962
7 * Hide tasks with due date someday, #931376
8 * New Date class by Paul Kishimoto and Izidor Matušov
9 * Parse due:3 as next 3rd day in month
10
11=== modified file 'GTG/gtk/editor/taskview.py'
12--- GTG/gtk/editor/taskview.py 2012-05-20 19:05:20 +0000
13+++ GTG/gtk/editor/taskview.py 2012-06-21 03:19:18 +0000
14@@ -713,8 +713,13 @@
15 buff.create_mark("/%s"%my_word, word_end, False)
16 #adding tag to a local list
17 new_tags.append(my_word)
18- #adding tag to the model
19- self.add_tag_callback(my_word)
20+ # Added to solve the bug 1001962
21+ word_end.forward_char()
22+ check_word = buff.get_text(word_start, word_end)
23+ #Get the last char of word and see if is space
24+ if(check_word[-1] == ' '):
25+ #adding tag to the model
26+ self.add_tag_callback(my_word)
27
28 # We set new word boundaries
29 word_start = char_end.copy()

Subscribers

People subscribed via source and target branches

to status/vote changes: