Merge ~gsilvapt/kubuntu-packaging/+git/ksirk:kubuntu_unstable into ~kubuntu-packagers/kubuntu-packaging/+git/ksirk:kubuntu_unstable
Proposed by
Gustavo Silva
on 2017-08-22
| Status: | Needs review |
|---|---|
| Proposed branch: | ~gsilvapt/kubuntu-packaging/+git/ksirk:kubuntu_unstable |
| Merge into: | ~kubuntu-packagers/kubuntu-packaging/+git/ksirk:kubuntu_unstable |
| Diff against target: |
34 lines (+8/-1) (has conflicts) 3 files modified
debian/control (+6/-0) debian/ksirk.lintian-overrides (+1/-1) debian/not-installed (+1/-0) Conflict in debian/control |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rik Mills | 2017-08-22 | Needs Fixing on 2017-08-22 | |
|
Review via email:
|
|||
Description of the Change
Fix KCI build failures.
Builds locally: http://
To post a comment you must log in.
| Gustavo Silva (gsilvapt) wrote : | # |
Hunk #1 - super strange. It's not duplicate on this end. I'm not sure what I did there, I'll try checking after pushing.
Hunk #2 - Fixed, thanks!
| Clive Johnston (clivejo) wrote : | # |
1) Please resolve the merge marker in d/control
2) In d/ksirk.
3) The file /etc/xdg/
Unmerged commits
- 52d5858... by Gustavo Silva on 2017-08-22
- 8535a50... by Gustavo Silva on 2017-08-22
- e9b70e2... by Gustavo Silva on 2017-08-22
- 62ef82e... by Gustavo Silva on 2017-08-22

Hunk #1 - why are you adding a set of duplicated build depends between those <<<<< / >>>>> markers? Looks like an error.
Hunk #2 - the k was missed from ksirk on the lintian override
Hunk #3 - etc/xdg/ksirk.knsrc needs to be installed, not added to not-installed