Merge ~gsilvapt/kubuntu-packaging/+git/ksirk:kubuntu_unstable into ~kubuntu-packagers/kubuntu-packaging/+git/ksirk:kubuntu_unstable

Proposed by Gustavo Silva on 2017-08-22
Status: Needs review
Proposed branch: ~gsilvapt/kubuntu-packaging/+git/ksirk:kubuntu_unstable
Merge into: ~kubuntu-packagers/kubuntu-packaging/+git/ksirk:kubuntu_unstable
Diff against target: 34 lines (+8/-1) (has conflicts)
3 files modified
debian/control (+6/-0)
debian/ksirk.lintian-overrides (+1/-1)
debian/not-installed (+1/-0)
Conflict in debian/control
Reviewer Review Type Date Requested Status
Rik Mills 2017-08-22 Needs Fixing on 2017-08-22
Review via email: mp+329403@code.launchpad.net

Description of the Change

Fix KCI build failures.
Builds locally: http://paste.ubuntu.com/25373070/

To post a comment you must log in.
Rik Mills (rikmills) wrote :

Hunk #1 - why are you adding a set of duplicated build depends between those <<<<< / >>>>> markers? Looks like an error.

Hunk #2 - the k was missed from ksirk on the lintian override

Hunk #3 - etc/xdg/ksirk.knsrc needs to be installed, not added to not-installed

review: Needs Fixing
Gustavo Silva (gsilvapt) wrote :

Hunk #1 - super strange. It's not duplicate on this end. I'm not sure what I did there, I'll try checking after pushing.

Hunk #2 - Fixed, thanks!

Clive Johnston (clivejo) wrote :

1) Please resolve the merge marker in d/control
2) In d/ksirk.lintian-overrides the package name is ksirk not irk, please fix this typo
3) The file /etc/xdg/ksirk.knsrc needs to be installed, please remove it from not-installed and place it in the proper install file

Unmerged commits

52d5858... by Gustavo Silva on 2017-08-22

Added rule to file missing

8535a50... by Gustavo Silva on 2017-08-22

Change lintian override path to new specification

e9b70e2... by Gustavo Silva on 2017-08-22

Added version of dependency

62ef82e... by Gustavo Silva on 2017-08-22

Fix b-d for KF5 and QT5

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/control b/debian/control
2index ec2d6cb..56cbcc8 100644
3--- a/debian/control
4+++ b/debian/control
5@@ -28,9 +28,15 @@ Build-Depends: cmake,
6 libkf5wallet-dev (>= 5.15.0),
7 libkf5widgetsaddons-dev (>= 5.15.0),
8 libkf5xmlgui-dev (>= 5.15.0),
9+<<<<<<< debian/control
10 libphonon4qt5-dev,
11 libqca-qt5-2-dev (>= 2.1.0),
12 libqt5svg5-dev (>= 5.2.0),
13+=======
14+ libphonon4qt5-dev (>= 4.9.51),
15+ libqca-qt5-2-dev (>= 2.1.0),
16+ libqt5svg5-dev(>= 5.2.0),
17+>>>>>>> debian/control
18 pkg-config,
19 pkg-kde-tools (>= 0.14),
20 qtbase5-dev (>= 5.2.0),
21diff --git a/debian/ksirk.lintian-overrides b/debian/ksirk.lintian-overrides
22index edb5c63..62852a3 100644
23--- a/debian/ksirk.lintian-overrides
24+++ b/debian/ksirk.lintian-overrides
25@@ -1 +1 @@
26-ksirk: embedded-library usr/games/ksirk: libidn
27+irk: embedded-library usr/lib/*/libiris_ksirk.so.2.0.0: libidn
28diff --git a/debian/not-installed b/debian/not-installed
29index 879d216..6488784 100644
30--- a/debian/not-installed
31+++ b/debian/not-installed
32@@ -1 +1,2 @@
33 ./usr/lib/libiris_ksirk.a
34+./etc/xdg/ksirk.knsrc

Subscribers

People subscribed via source and target branches