Merge lp:~gruemaster/flash-kernel/no-mtd into lp:ubuntu/precise/flash-kernel

Proposed by Tobin Davis on 2012-03-02
Status: Merged
Merge reported by: Oliver Grawert
Merged at revision: not available
Proposed branch: lp:~gruemaster/flash-kernel/no-mtd
Merge into: lp:ubuntu/precise/flash-kernel
Diff against target: 37 lines (+17/-3)
1 file modified
flash-kernel (+17/-3)
To merge this branch: bzr merge lp:~gruemaster/flash-kernel/no-mtd
Reviewer Review Type Date Requested Status
Oliver Grawert Approve on 2012-03-02
Ubuntu branches 2012-03-02 Pending
Review via email: mp+95618@code.launchpad.net

Description of the Change

Fixes bug 626749.

To post a comment you must log in.
Oliver Grawert (ogra) wrote :

looks good, especially that you take into account that the SDP4430 (blaze) only has an eMMC (mmcblk1p1), you should adjust the comment in the blaze section though, but thats not a merge blocker

review: Approve
Daniel Holbach (dholbach) wrote :

It appears this was merged in a slightly different way.

Oliver Grawert (ogra) wrote :

line 8-12 seem to have come from a former edit, i merged the latter parts and uploaded though.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'flash-kernel'
2--- flash-kernel 2012-01-30 11:56:25 +0000
3+++ flash-kernel 2012-03-02 16:57:17 +0000
4@@ -682,7 +682,10 @@
5 case $subarch in
6 "mx5"|"mx51")
7 :
8- ;;
9+ ;; if [ -n "${UBOOT_PART}" ]; then
10+ UBOOT_PART=/dev/mmcblk0p1
11+ fi
12+
13 *)
14 # Not actually the real expected kfile
15 # subarch, but will raise a sensible error
16@@ -849,8 +852,19 @@
17 "IGEP v2 board"|"OMAP3 Beagle Board")
18 check_subarch "omap"
19 ;;
20- "OMAP4430 4430SDP board" | "OMAP4430 Panda Board" | "OMAP4 Panda board")
21- check_subarch "omap4"
22+ "OMAP4430 Panda Board" | "OMAP4 Panda board")
23+ check_subarch "omap4"
24+ if [ -z "${UBOOT_PART}" ]; then
25+ # these boards do not have mtd, only mmc.
26+ export UBOOT_PART=/dev/mmcblk0p1
27+ fi
28+ ;;
29+ "OMAP4430 4430SDP board")
30+ check_subarch "omap4"
31+ if [ -z "${UBOOT_PART}" ]; then
32+ # these boards do not have mtd, only mmc.
33+ export UBOOT_PART=/dev/mmcblk1p1
34+ fi
35 ;;
36 esac
37 omap_flash_kernel

Subscribers

People subscribed via source and target branches

to all changes: