Merge lp:~gruemaster/bacula/960761 into lp:ubuntu/precise/bacula

Proposed by Tobin Davis
Status: Merged
Merged at revision: 84
Proposed branch: lp:~gruemaster/bacula/960761
Merge into: lp:ubuntu/precise/bacula
Diff against target: 93 lines (+17/-10)
3 files modified
debian/bacula-director-mysql.templates (+1/-1)
debian/bacula-director-pgsql.templates (+9/-9)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~gruemaster/bacula/960761
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+99137@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Well, it's inaccurate to describe this as a typo. The leading _ is for translations, as documented in the po-debconf(7) manual page.

However, the transition to po-debconf has clearly been botched here: most notably, there's no debian/po/POTFILES.in. More to the point, perhaps, I really can't see us doing an extensive call for translations etc. when the package has no debconf translations in Debian. So, with the exception of s/precise/lucid/ in debian/changelog (which I'll take care of), this looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/bacula-director-mysql.templates'
2--- debian/bacula-director-mysql.templates 2010-03-14 02:19:12 +0000
3+++ debian/bacula-director-mysql.templates 2012-03-23 23:48:19 +0000
4@@ -46,7 +46,7 @@
5
6 Template: bacula/notconfigured
7 Type: note
8-_Description: Warning - Bacula is not configured
9+Description: Warning - Bacula is not configured
10 Please note that you have not completed the Bacula configuration. For
11 completing it, please use "dpkg-reconfigure bacula-director-mysql" later.
12
13
14=== modified file 'debian/bacula-director-pgsql.templates'
15--- debian/bacula-director-pgsql.templates 2009-01-20 07:45:53 +0000
16+++ debian/bacula-director-pgsql.templates 2012-03-23 23:48:19 +0000
17@@ -1,52 +1,52 @@
18 Template: bacula/db_host
19 Type: string
20 Default: localhost
21-_Description: Database server hostname:
22+Description: Database server hostname:
23 Please enter the hostname of the database server host.
24
25 Template: bacula/dba_name
26 Type: string
27 Default: root
28-_Description: Database administrator username:
29+Description: Database administrator username:
30 Please enter the PostgreSQL administrator username, needed for
31 the database creation.
32
33 Template: bacula/dba_password
34 Type: password
35-_Description: Database administrator password:
36+Description: Database administrator password:
37 Please enter the PostgreSQL administrator password, needed for
38 the database creation.
39
40 Template: bacula/dba_confirm
41 Type: password
42-_Description: DBA password confirmation:
43+Description: DBA password confirmation:
44 Please confirm the password in order to continue the process.
45
46 Template: bacula/mismatch
47 Type: note
48-_Description: Password mismatch
49+Description: Password mismatch
50 The password and its confirmation do not match. Please
51 reenter the passwords.
52
53 Template: bacula/dbu_name
54 Type: string
55 Default: bacula
56-_Description: Database owner username:
57+Description: Database owner username:
58 Please enter the username of the Bacula database owner.
59
60 Template: bacula/dbu_password
61 Type: password
62-_Description: Database owner password:
63+Description: Database owner password:
64 Please enter the password of the Bacula database owner.
65
66 Template: bacula/dbu_confirm
67 Type: password
68-_Description: Database user password confirmation:
69+Description: Database user password confirmation:
70 Please confirm the password of the Bacula database owner.
71
72 Template: bacula/notconfigured
73 Type: note
74-_Description: Warning - Bacula is not configured
75+Description: Warning - Bacula is not configured
76 Please note that you have not completed the Bacula configuration. For
77 completing it, please use "dpkg-reconfigure bacula-director-pgsql" later.
78
79
80=== modified file 'debian/changelog'
81--- debian/changelog 2012-03-07 21:32:43 +0000
82+++ debian/changelog 2012-03-23 23:48:19 +0000
83@@ -1,3 +1,10 @@
84+bacula (5.2.5-0ubuntu6) lucid; urgency=low
85+
86+ * Fix templates for dpkg installation of
87+ backula-director-[mysql|pgsql] packages. (LP: #960761)
88+
89+ -- Tobin <tobin@razman.gruenet> Fri, 23 Mar 2012 16:32:16 -0700
90+
91 bacula (5.2.5-0ubuntu5) precise; urgency=low
92
93 * Add libncurses-dev to build-depends, as the console client insists

Subscribers

People subscribed via source and target branches

to all changes: