Merge ~graylog-charmers/charm-graylog:core-resource into ~graylog-charmers/charm-graylog:master
Status: | Merged |
---|---|
Approved by: | Kevin W Monroe |
Approved revision: | 9d710af3c27605ce2353b6ef57e09834339e20ed |
Merged at revision: | f233dad8109e352ae4fb923a1deb9e5d47336b75 |
Proposed branch: | ~graylog-charmers/charm-graylog:core-resource |
Merge into: | ~graylog-charmers/charm-graylog:master |
Diff against target: |
63 lines (+31/-0) 3 files modified
Makefile (+25/-0) layer.yaml (+2/-0) metadata.yaml (+4/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | canonical-is-reviewers | Approve | |
George Kraft (community) | Approve | ||
Canonical IS Reviewers | Pending | ||
Review via email: mp+367201@code.launchpad.net |
Commit message
lp:1828063 add a core.snap resource to facilitate offline installs
Description of the change
The core snap is required by the graylog snap. To facilitate offline deployment, users need the ability to attach a core.snap resource in addition to the graylog.snap resource.
A downside of this is that future graylog charm releases will need to have a zero-byte core.snap resource attached, as in:
rm /tmp/core.snap && touch /tmp/core.snap
charm push /path/to/
charm release <graylog-X> --resource core-0 --resource graylog-Y
For normal deployments, layer-snap will recognize that core.snap is a 0-byte resource and will fall back to installing from the snap store. For offline deployments, users will need to attach the desired core.snap, as in:
juju deploy /path/to/
--resource core=/path/
--resource graylog=
Also in offline deployments, we need to ensure the coren.snap is installed prior to graylog.snap, hence this is dependent on:
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.