Merge lp:~graeme-acm/sahana-eden/LA into lp:sahana-eden/la

Proposed by Graeme Foster
Status: Merged
Merged at revision: 2705
Proposed branch: lp:~graeme-acm/sahana-eden/LA
Merge into: lp:sahana-eden/la
Diff against target: 96 lines (+31/-29)
3 files modified
controllers/don.py (+24/-22)
static/styles/S3/sahana.css (+4/-4)
views/layout.html (+3/-3)
To merge this branch: bzr merge lp:~graeme-acm/sahana-eden/LA
Reviewer Review Type Date Requested Status
Fran Boon Pending
Review via email: mp+74164@code.launchpad.net

Description of the change

Fixed log 296

Spotted a bug in the logic for the donation request button

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'controllers/don.py'
2--- controllers/don.py 2011-09-05 15:50:16 +0000
3+++ controllers/don.py 2011-09-06 06:48:25 +0000
4@@ -164,28 +164,30 @@
5
6 # Defined in the Model for use from Multiple Controllers for unified menus
7 output = response.s3.req_controller()
8- output["rheader"].append(
9- DIV(
10- BUTTON(T("Donation Request Form"),
11- _class="accept-button",
12- _onClick="javascript: window.location='%s'" % \
13- URL(c=request.controller,
14- f="req_print",
15- args=[request.args[0]]
16- )
17- ),
18- # Also in controllers/vol.py - DRY
19- A(IMG(_src="/%s/static/img/get_adobe_reader.png" % request.application,
20- _title="%s - %s" % (T("Get Adobe Reader"),
21- T("This link will open a new browser window.")),
22- _alt=T("Get Adobe Reader"),
23- _width=158,
24- _height=39,
25- _style="float:right;"),
26- _href="http://www.adobe.com/products/acrobat/readstep2.html",
27- _target="_blank"),
28- )
29- )
30+ reportButtons = DIV(
31+ BUTTON(T("Donation Request Form"),
32+ _class="accept-button",
33+ _onClick="javascript: window.location='%s'" % \
34+ URL(c=request.controller,
35+ f="req_print",
36+ args=request.args
37+ )
38+ ),
39+ # Also in controllers/vol.py - DRY
40+ A(IMG(_src="/%s/static/img/get_adobe_reader.png" % request.application,
41+ _title="%s - %s" % (T("Get Adobe Reader"),
42+ T("This link will open a new browser window.")),
43+ _alt=T("Get Adobe Reader"),
44+ _width=158,
45+ _height=39,
46+ _style="float:right;"),
47+ _href="http://www.adobe.com/products/acrobat/readstep2.html",
48+ _target="_blank"),
49+ )
50+ if "rheader" in output:
51+ output["rheader"].append(reportButtons)
52+ else:
53+ output["rheader"] = reportButtons
54 return output
55
56 def req_print():
57
58=== modified file 'static/styles/S3/sahana.css'
59--- static/styles/S3/sahana.css 2011-09-05 15:50:16 +0000
60+++ static/styles/S3/sahana.css 2011-09-06 06:48:25 +0000
61@@ -195,10 +195,10 @@
62 #header{overflow:hidden;position:relative;}
63 #header #la-logo, #header #logo{float:left;}
64 #header #la-logo{margin-top:24px;}
65-#header #logo{margin:55px 0px 0px 70px;}
66-
67-/*#header #personal-menu{float:right;width:50%;margin-right:0px;font-size:0.90em;}*/
68-#header #personal-menu{float:right;width:400px;margin-right:0px;font-size:0.90em;}
69+#header #logo{margin:12px 0px 0px 70px;}
70+
71+
72+#header #personal-menu{float:right;width:798px;margin-right:0px;font-size:0.90em;}
73 #header #personal-menu .pmenu-wrapper{float:right;}
74 #header #personal-menu *{float:left;}
75 #header #personal-menu ul{border-right:1px #6994bc solid;padding-bottom:5px;}
76
77=== modified file 'views/layout.html'
78--- views/layout.html 2011-09-05 15:50:16 +0000
79+++ views/layout.html 2011-09-06 06:48:25 +0000
80@@ -74,13 +74,13 @@
81 <img src='/{{=request.application}}/static/img/la/cityofla_logo.png' height='114' width='112' alt='{{=T("City of Los Angeles Emergency Management Department")}}' />
82 </a>
83 </div>
84+ <div id='personal-menu'>
85+ {{=MENUS3(response.menu, _type="personal-menu", _current_lang=request.vars.get("_language"), _menu_langs=s3.menu_lang)}}
86+ </div>
87 <div id='logo'>
88 <a href='/{{=request.application}}' title='{{=T("Return to Home Page")}}'>
89 <img src='/{{=request.application}}/static/img/la/logo.png' height='58' width='284' alt='{{=T("Give to Los Angeles Logo")}}' />
90 </a>
91- </div>
92- <div id='personal-menu'>
93- {{=MENUS3(response.menu, _type="personal-menu", _current_lang=request.vars.get("_language"), _menu_langs=s3.menu_lang)}}
94 </div>
95 <a href='#main-content' class='skipnavigation'>Skip to Content</a>
96 {{=MENUS3(response.menu, _type="nav", _id="nav", _highlight=request["wsgi"]["environ"]["PATH_INFO"])}}

Subscribers

People subscribed via source and target branches

to all changes: