Merge lp:~gothicx/entertainer/change_gnomexfce into lp:entertainer

Proposed by Marco Rodrigues
Status: Rejected
Rejected by: Paul Hummer
Proposed branch: lp:~gothicx/entertainer/change_gnomexfce
Merge into: lp:entertainer
To merge this branch: bzr merge lp:~gothicx/entertainer/change_gnomexfce
Reviewer Review Type Date Requested Status
Matt Layman Disapprove
Review via email: mp+2698@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Matt Layman (mblayman) wrote :

I understand that this is subtlely different from the your other merge proposal for this branch (0.3 vs trunk as the target), but I think that you don't need to provide this level of effort in the future.

If a branch is approved for merging into somthing other than the trunk, it will either be merged onto that release (or subsequent point release) or we'll merged it on to the trunk shortly after. For example, we might not merge the branch onto a release branch if it doesn't fix a critical bug right shortly before release, but if we approve it, you can be pretty certain that we'll merge it onto trunk.

Thanks for being thorough though.

review: Disapprove
Revision history for this message
Marco Rodrigues (gothicx) wrote :

Hi!

Ah ok. So when I do a push, it proposees automatically to the trunk (current development), or I need to propose the merge ?

Thanks

Revision history for this message
Marco Rodrigues (gothicx) wrote :

You'll apply this change to the trunk, or I need to propose it again, but now against trunk ?

Unmerged revisions

Subscribers

People subscribed via source and target branches